html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/1394#issuecomment-298688491,https://api.github.com/repos/pydata/xarray/issues/1394,298688491,MDEyOklzc3VlQ29tbWVudDI5ODY4ODQ5MQ==,1217238,2017-05-02T16:32:07Z,2017-05-02T16:32:07Z,MEMBER,"> 0.9.3 OK, so that shouldn't be a problem. Hmm. My only suggestion is that we should think about trying to write a fuller test suite for the auto-close functionality, using a mock or fake of some sort that we can interrogate to verify it works properly. One simple thing would be to refactor the autoclose functionality into a single separate *adaptor* datastore (which wraps an underlying datastore) that we can more easily test, rather than putting it onto each of the underlying datastore classes. I'm not sure why I didn't think of that when @pwolfram was writing this before.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,225734529 https://github.com/pydata/xarray/issues/1394#issuecomment-298681206,https://api.github.com/repos/pydata/xarray/issues/1394,298681206,MDEyOklzc3VlQ29tbWVudDI5ODY4MTIwNg==,1217238,2017-05-02T16:06:18Z,2017-05-02T16:06:18Z,MEMBER,"Just to make sure, which version of xarray are you using?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,225734529