html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1330#issuecomment-302728009,https://api.github.com/repos/pydata/xarray/issues/1330,302728009,MDEyOklzc3VlQ29tbWVudDMwMjcyODAwOQ==,5356122,2017-05-19T15:05:39Z,2017-05-19T15:05:39Z,MEMBER,This has been sitting for a little while... @shoyer please don't let my comment keep you from merging- it was more to note that this introduces custom error types.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113
https://github.com/pydata/xarray/pull/1330#issuecomment-290578639,https://api.github.com/repos/pydata/xarray/issues/1330,290578639,MDEyOklzc3VlQ29tbWVudDI5MDU3ODYzOQ==,5356122,2017-03-31T00:01:10Z,2017-03-31T00:01:10Z,MEMBER,"I'm thinking about some of the ones in `alignment.py` which are currently `ValueError`, for example: https://github.com/pydata/xarray/blob/master/xarray/core/alignment.py#L303","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113
https://github.com/pydata/xarray/pull/1330#issuecomment-290572513,https://api.github.com/repos/pydata/xarray/issues/1330,290572513,MDEyOklzc3VlQ29tbWVudDI5MDU3MjUxMw==,5356122,2017-03-30T23:20:59Z,2017-03-30T23:20:59Z,MEMBER,"> Does it seem useful to you?

Yes, it's a nice sanity check.

> Does the name join='exact' make sense?

Yes.

> Any thoughts on this feature?

Is it worth introducing custom exception types into xarray? Seems like `ValueError` would be fine here. Then users can write this without having to know we use our own special exceptions:
```
try:
   xarray.merge([ds1, ds2], join='exact')
except ValueError:
   ...
```

Otherwise you'll probably want to change some others to `AlignmentError` for consistency.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,217287113