html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1251#issuecomment-1111431038,https://api.github.com/repos/pydata/xarray/issues/1251,1111431038,IC_kwDOAMm_X85CPxd-,5635139,2022-04-27T20:06:24Z,2022-04-27T20:06:24Z,MEMBER,"FYI the `apply` / `map` change went in a couple of years ago.
We still don't have an `apply_raw`. I think it probably makes sense to consolidate this with https://github.com/pydata/xarray/issues/1618, so I'll close this, even though it has some good discussion.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788
https://github.com/pydata/xarray/issues/1251#issuecomment-550035303,https://api.github.com/repos/pydata/xarray/issues/1251,550035303,MDEyOklzc3VlQ29tbWVudDU1MDAzNTMwMw==,5635139,2019-11-05T21:44:44Z,2019-11-05T21:44:44Z,MEMBER,"OK. Does that inform your view on `map` vs `apply`?
I more strongly think that `apply` is a confusing and non-standard term for ""run this function on _each item_ in this container"", even if it's pandas' name.
I'm keener to offer `map` an as option that necessarily reusing `apply`.
What are your thoughts re:
- Adding `map` as the documented approach for run-on-each on `Dataset` & `GroupBy`
- Adding `apply_raw` (or similar) as a new function that runs functions on the 'raw' arrays
- Keeping `apply` around for backward-compat, similar to the `drop` case","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788
https://github.com/pydata/xarray/issues/1251#issuecomment-547592571,https://api.github.com/repos/pydata/xarray/issues/1251,547592571,MDEyOklzc3VlQ29tbWVudDU0NzU5MjU3MQ==,5635139,2019-10-29T19:32:14Z,2019-10-30T00:22:56Z,MEMBER,"I put the change for `Dataset.apply` -> `Dataset.map` in. Should we do the same for `GroupBy`?
I think those are probably the two easiest decisions to make (and hopefully will kick off moving this issue forwards)
Edit: the reason I hesitated for `GroupBy` is that it's not exactly the same: the object returned isn't the same (i.e. `Dataset.map` returns a `Dataset`, while `GroupBy.map` would return a `Dataset`)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788
https://github.com/pydata/xarray/issues/1251#issuecomment-455353612,https://api.github.com/repos/pydata/xarray/issues/1251,455353612,MDEyOklzc3VlQ29tbWVudDQ1NTM1MzYxMg==,5635139,2019-01-17T22:21:06Z,2019-01-17T22:21:06Z,MEMBER,"> I would like to rename rolling.reduce to rolling.apply to be consistent with pandas & groupby
+0.5 if `map` fails","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788
https://github.com/pydata/xarray/issues/1251#issuecomment-455349535,https://api.github.com/repos/pydata/xarray/issues/1251,455349535,MDEyOklzc3VlQ29tbWVudDQ1NTM0OTUzNQ==,5635139,2019-01-17T22:06:05Z,2019-01-17T22:06:05Z,MEMBER,"> One proposal: rename apply to map
Would we accept this? I'd be up for doing the PR to deprecate `apply` and introduce `map`. It makes a Dataset more consistent with a standard mapping interface. But it would be inconsistent with pandas and a rename of fairly widely used method","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788
https://github.com/pydata/xarray/issues/1251#issuecomment-277576392,https://api.github.com/repos/pydata/xarray/issues/1251,277576392,MDEyOklzc3VlQ29tbWVudDI3NzU3NjM5Mg==,5635139,2017-02-06T03:01:06Z,2017-02-06T03:01:06Z,MEMBER,"Sounds good. It breaks the consistency with pandas' `apply`, but `map` is much more logical","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205455788