html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1204#issuecomment-274641832,https://api.github.com/repos/pydata/xarray/issues/1204,274641832,MDEyOklzc3VlQ29tbWVudDI3NDY0MTgzMg==,5572303,2017-01-23T22:43:32Z,2017-01-23T22:43:32Z,CONTRIBUTOR,tears in my eyes.......,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-274641120,https://api.github.com/repos/pydata/xarray/issues/1204,274641120,MDEyOklzc3VlQ29tbWVudDI3NDY0MTEyMA==,1217238,2017-01-23T22:40:23Z,2017-01-23T22:40:23Z,MEMBER,"Thanks for persevering on this, @chunweiyuan ! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-274574880,https://api.github.com/repos/pydata/xarray/issues/1204,274574880,MDEyOklzc3VlQ29tbWVudDI3NDU3NDg4MA==,5572303,2017-01-23T18:30:14Z,2017-01-23T18:30:14Z,CONTRIBUTOR,checking in on this PR...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-274195788,https://api.github.com/repos/pydata/xarray/issues/1204,274195788,MDEyOklzc3VlQ29tbWVudDI3NDE5NTc4OA==,5572303,2017-01-20T22:22:01Z,2017-01-20T22:22:01Z,CONTRIBUTOR,time to merge this guy?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-273677944,https://api.github.com/repos/pydata/xarray/issues/1204,273677944,MDEyOklzc3VlQ29tbWVudDI3MzY3Nzk0NA==,1217238,2017-01-19T04:15:23Z,2017-01-19T04:15:23Z,MEMBER,Looks like the build is starting now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-273677902,https://api.github.com/repos/pydata/xarray/issues/1204,273677902,MDEyOklzc3VlQ29tbWVudDI3MzY3NzkwMg==,1217238,2017-01-19T04:14:59Z,2017-01-19T04:14:59Z,MEMBER,"Appveyor is acting up. I tried cancelling and restarting the build -- we'll see if that works. But the Travis-CI tests pass, so I wouldn't worry about.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-273676997,https://api.github.com/repos/pydata/xarray/issues/1204,273676997,MDEyOklzc3VlQ29tbWVudDI3MzY3Njk5Nw==,5572303,2017-01-19T04:06:45Z,2017-01-19T04:06:45Z,CONTRIBUTOR,I'm not sure why continuous integration check is taking forever.....,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-272651348,https://api.github.com/repos/pydata/xarray/issues/1204,272651348,MDEyOklzc3VlQ29tbWVudDI3MjY1MTM0OA==,1217238,2017-01-14T20:39:18Z,2017-01-14T20:39:18Z,MEMBER,"I would simply copy attributes from the first argument for keep_attrs. We
don't do any complex merging of attributes on any xarray methods.

On Sat, Jan 14, 2017 at 10:04 AM chunweiyuan <notifications@github.com>
wrote:

> *@chunweiyuan* commented on this pull request.
>
>
>
>
> ------------------------------
>
>
>
>
> In xarray/core/groupby.py <https://github.com/pydata/xarray/pull/1204>:
>
>
> > @@ -382,7 +382,15 @@ def fillna(self, value):
>
>          Dataset.fillna
>
>          DataArray.fillna
>
>          """"""
>
> -        return self._fillna(value)
>
> +        def _yield_applied(this, other):
>
>
>
> I copped out and took your simple approach. It's mainly because I'm not
> sure how to deal with more than 2 objects in apply_ufunc when
> keep_attrs=True. Do I only take the first object's attributes? Maybe best
> left for another PR.
>
>
>
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1204>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1gFM7BNe3Bc60Q_02T25AOWAS5GRks5rSQ4bgaJpZM4LiOvZ>
> .
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981
https://github.com/pydata/xarray/pull/1204#issuecomment-272582190,https://api.github.com/repos/pydata/xarray/issues/1204,272582190,MDEyOklzc3VlQ29tbWVudDI3MjU4MjE5MA==,5572303,2017-01-14T00:14:17Z,2017-01-14T00:14:17Z,CONTRIBUTOR,"So I addressed some of the comments, but not all.  Please let me know what you think.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,200478981