html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1197#issuecomment-326144658,https://api.github.com/repos/pydata/xarray/issues/1197,326144658,MDEyOklzc3VlQ29tbWVudDMyNjE0NDY1OA==,1217238,2017-08-30T23:12:59Z,2017-08-30T23:12:59Z,MEMBER,"> Do we still want to deprecate this behavior in v0.10?
Sure, that seems reasonable to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-326136580,https://api.github.com/repos/pydata/xarray/issues/1197,326136580,MDEyOklzc3VlQ29tbWVudDMyNjEzNjU4MA==,2443309,2017-08-30T22:25:55Z,2017-08-30T22:25:55Z,MEMBER,"> o I think we should keep the deprecation warning around for a while before making this behavior an error (probably in v0.10)
@shoyer - Do we still want to deprecate this behavior in v0.10?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-271928169,https://api.github.com/repos/pydata/xarray/issues/1197,271928169,MDEyOklzc3VlQ29tbWVudDI3MTkyODE2OQ==,1217238,2017-01-11T17:07:23Z,2017-01-11T17:07:23Z,MEMBER,"@SpghttCd Yes, I was confused. I missed that you were writing `np.zeros`, so reply doesn't make much sense!
On master (and in the next release of xarray), we do indeed issue a warning here as @fmaussion points out. Unfortunately, we did support this behavior in prior releases of xarray (especially with an `OrderedDict`), so I think we should keep the deprecation warning around for a while before making this behavior an error (probably in v0.10).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-271904169,https://api.github.com/repos/pydata/xarray/issues/1197,271904169,MDEyOklzc3VlQ29tbWVudDI3MTkwNDE2OQ==,10050469,2017-01-11T15:47:50Z,2017-01-11T15:47:50Z,MEMBER,@shoyer maybe changing the warning into an error would be the way to go now? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-271903682,https://api.github.com/repos/pydata/xarray/issues/1197,271903682,MDEyOklzc3VlQ29tbWVudDI3MTkwMzY4Mg==,10050469,2017-01-11T15:46:19Z,2017-01-11T15:46:37Z,MEMBER,"Note that the recommended to build data arrays is to specify the dimensions names explicitly:
```
In [11]: xr.DataArray(np.zeros([1, 2, 3]), {'x': [1], 'y': [1, 2], 'z': [1, 2, 3]},
dims=['x', 'y', 'z'])
Out[11]:
array([[[ 0., 0., 0.],
[ 0., 0., 0.]]])
Coordinates:
* y (y) int64 1 2
* z (z) int64 1 2 3
* x (x) int64 1
```
on master, failing to do so results in a ``FutureWarning`` (which is the important message, but gets lost in the traceback) and then in a ``ValueError`` (which might be confusing):
```
In [12]: xr.DataArray(np.zeros([1, 2, 3]), {'x': [1], 'y': [1, 2], 'z': [1, 2, 3]})
/home/mowglie/.pyvirtualenvs/py3/bin/ipython:1: FutureWarning: inferring DataArray dimensions from dictionary like ``coords`` has been deprecated. Use an explicit list of ``dims`` instead.
#!/home/mowglie/.pyvirtualenvs/py3/bin/python3
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
in ()
----> 1 xr.DataArray(np.zeros([1, 2, 3]), {'x': [1], 'y': [1, 2], 'z': [1, 2, 3]})
/home/mowglie/Documents/git/xarray/xarray/core/dataarray.py in __init__(self, data, coords, dims, name, attrs, encoding, fastpath)
219
220 data = as_compatible_data(data)
--> 221 coords, dims = _infer_coords_and_dims(data.shape, coords, dims)
222 variable = Variable(dims, data, attrs, encoding, fastpath=True)
223
/home/mowglie/Documents/git/xarray/xarray/core/dataarray.py in _infer_coords_and_dims(shape, coords, dims)
83 raise ValueError('conflicting sizes for dimension %r: '
84 'length %s on the data but length %s on '
---> 85 'coordinate %r' % (d, sizes[d], s, k))
86
87 assert_unique_multiindex_level_names(new_coords)
ValueError: conflicting sizes for dimension 'y': length 1 on the data but length 2 on coordinate 'y'
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-271864879,https://api.github.com/repos/pydata/xarray/issues/1197,271864879,MDEyOklzc3VlQ29tbWVudDI3MTg2NDg3OQ==,25030860,2017-01-11T13:12:32Z,2017-01-11T13:12:32Z,NONE,"Hello, thanks for the immediate reply - and to seize the opportunity: thanks for this really great library, which I think will be _the_ enabler for me to - finally - use netCDF4 for my measurement facility like I wished for years now.
However, I have to disagree in your point regarding the not fitting dimensions in the DataArray definition. np.zeros() will for sure return an n-dimensional array when called with a length-n list as argument, which I did with n=3 and the list [1,2,3].
I.e. calling `np.zeros([1, 2, 3])`
will return `array([ [ [ 0., 0., 0.], [ 0., 0., 0.] ] ])`
Besides, the working alternatives with tuples or the OrderedDict use the very same dummy array for initializing in the example above.
Further I estimate the 0.8.2-error-message completely consistent: it (silently) acknowledges that there are three dimensions in both the zeros-array and the coords by reporting a problem about not fitting lengths of the third one of each, 'z'.
Though by adding a one-dimensional dims-definition, you turn the following error messages away from the original problem, now indeed introducing an inconsistency in dimensions between dims and data.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142
https://github.com/pydata/xarray/issues/1197#issuecomment-271715645,https://api.github.com/repos/pydata/xarray/issues/1197,271715645,MDEyOklzc3VlQ29tbWVudDI3MTcxNTY0NQ==,1217238,2017-01-10T22:16:33Z,2017-01-10T22:16:33Z,MEMBER,"You shouldn't be able to make a DataArray like this -- you have three dimensions on coordinates, but only one dimension on the array itself.
With xarray 0.8.2, you get an error message with your example:
```
import xarray as xr
arr = xr.DataArray(np.zeros([1, 2, 3]), {'x': [1], 'y': [1, 2], 'z': [1, 2, 3]})
```
```
ValueError: conflicting sizes for dimension 'z': length 1 on the data but length 3 on coordinate 'z'
```
However, this error message is not quite accurate. You need to explicitly provide `dims` to get a sensible error:
```
arr = xr.DataArray(np.zeros([1, 2, 3]), {'x': [1], 'y': [1, 2], 'z': [1, 2, 3]}, dims=['x'])
```
```
ValueError: coordinate z has dimensions ('z',), but these are not a subset of the DataArray dimensions ['x']
```
I still need to test this on the dev version, but for now I will make this as an error reporting bug.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,199816142