html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1162#issuecomment-274605154,https://api.github.com/repos/pydata/xarray/issues/1162,274605154,MDEyOklzc3VlQ29tbWVudDI3NDYwNTE1NA==,1217238,2017-01-23T20:20:51Z,2017-01-23T20:20:51Z,MEMBER,"OK, build passed so I'm merging. Thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296 https://github.com/pydata/xarray/pull/1162#issuecomment-274582165,https://api.github.com/repos/pydata/xarray/issues/1162,274582165,MDEyOklzc3VlQ29tbWVudDI3NDU4MjE2NQ==,1217238,2017-01-23T18:55:49Z,2017-01-23T18:55:49Z,MEMBER,Looks good. Unfortunately there was a merge conflict with the quantile PR so you need to merge master again.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296 https://github.com/pydata/xarray/pull/1162#issuecomment-274565256,https://api.github.com/repos/pydata/xarray/issues/1162,274565256,MDEyOklzc3VlQ29tbWVudDI3NDU2NTI1Ng==,1217238,2017-01-23T17:56:09Z,2017-01-23T17:56:09Z,MEMBER,"Actually, if you want to write that now I think we can squeeze this in. We are still a day or two away from the release. On Mon, Jan 23, 2017 at 9:52 AM mangecoeur wrote: Note - waiting for 0.9.0 to be released before updating whats new, don't want to end up with conflicts in docs — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread . ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296 https://github.com/pydata/xarray/pull/1162#issuecomment-272743812,https://api.github.com/repos/pydata/xarray/issues/1162,272743812,MDEyOklzc3VlQ29tbWVudDI3Mjc0MzgxMg==,1217238,2017-01-15T22:40:04Z,2017-01-15T22:40:04Z,MEMBER,This looks great to me. I'll merge this shortly after releasing 0.9.0 -- could you please add a brief release note in a new section for 0.9.1? (It won't be a long wait.),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296 https://github.com/pydata/xarray/pull/1162#issuecomment-269086156,https://api.github.com/repos/pydata/xarray/issues/1162,269086156,MDEyOklzc3VlQ29tbWVudDI2OTA4NjE1Ng==,1217238,2016-12-24T14:20:23Z,2016-12-24T14:20:23Z,MEMBER,"I believe Dataset.transpose already skips variables that don't need to be transposed. On Sat, Dec 24, 2016 at 5:40 AM mangecoeur wrote: > *@mangecoeur* commented on this pull request. > ------------------------------ > > In xarray/core/dataset.py : > > > + coord_dim = var.dims[0] # should just be one? > + selection = take(var, indexers_dict[coord_dim]) > + > + sel_coords[c] = (dim, selection) > + else: > + sel_coords[c] = self.coords[c] > + > + variables = OrderedDict() > + > + for name in data_vars: > + var = self.variables[name] > + # Transpose the var to ensure that the indexed dims come first > + # These dims will be collapsed in the output. > + # To avoid edge cases in numpy want to transpose to ensure the indexed dimensions are first > + # However transpose is not lazy, so want to avoid using it for dask case (??) > + var = var.transpose(*(list(d for d in indexer_dims if d in var.dims) + > > I did that originally but then I thought that if there are variables that > are not indexed at all we can skip applying transpose to them this way (and > triggering a data load on them too). Does that make sense? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or mute the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296 https://github.com/pydata/xarray/pull/1162#issuecomment-268927666,https://api.github.com/repos/pydata/xarray/issues/1162,268927666,MDEyOklzc3VlQ29tbWVudDI2ODkyNzY2Ng==,1217238,2016-12-23T01:46:01Z,2016-12-23T01:46:01Z,MEMBER,The development version of xarray includes a change that makes indexes optional. So if you use the Dataset/DataArray constructor it no longer adds new coordinates for each dimension by default.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,195125296