html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1148#issuecomment-265457836,https://api.github.com/repos/pydata/xarray/issues/1148,265457836,MDEyOklzc3VlQ29tbWVudDI2NTQ1NzgzNg==,10050469,2016-12-07T14:16:51Z,2016-12-07T14:16:51Z,MEMBER,Thanks @hoonhout !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-265422603,https://api.github.com/repos/pydata/xarray/issues/1148,265422603,MDEyOklzc3VlQ29tbWVudDI2NTQyMjYwMw==,7442202,2016-12-07T11:21:27Z,2016-12-07T11:21:27Z,CONTRIBUTOR,"I think this request is now ready to be pulled, right?
Otherwise I keep merging these what's new lines :-)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264471550,https://api.github.com/repos/pydata/xarray/issues/1148,264471550,MDEyOklzc3VlQ29tbWVudDI2NDQ3MTU1MA==,950575,2016-12-02T14:53:28Z,2016-12-06T00:51:39Z,CONTRIBUTOR,"Ignore what I said. looking closer it makes sense to set the default to
True.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264485891,https://api.github.com/repos/pydata/xarray/issues/1148,264485891,MDEyOklzc3VlQ29tbWVudDI2NDQ4NTg5MQ==,10050469,2016-12-02T15:49:52Z,2016-12-02T15:49:52Z,MEMBER,Thanks @hoonhout ! We're still missing an entry on [whats-new.rst](https://github.com/pydata/xarray/blob/master/doc/whats-new.rst) ;),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264471623,https://api.github.com/repos/pydata/xarray/issues/1148,264471623,MDEyOklzc3VlQ29tbWVudDI2NDQ3MTYyMw==,7442202,2016-12-02T14:53:43Z,2016-12-02T14:53:43Z,CONTRIBUTOR,"Sure, I'll make my example into a test.
BTW, I would recommend to keep the default True.
Seaborn's default is indeed shared axes. This makes sense as a FacetGrid is intended to visualize single-source data.
MPL's default is indeed not to share axes. This also makes sense as MPL doesn't have any constraints on the data source.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264463656,https://api.github.com/repos/pydata/xarray/issues/1148,264463656,MDEyOklzc3VlQ29tbWVudDI2NDQ2MzY1Ng==,10050469,2016-12-02T14:18:42Z,2016-12-02T14:18:42Z,MEMBER,"This would likely brake existing code, so @shoyer has to decide upon this. The current defaults are probably inherited from [seaborn](http://seaborn.pydata.org/generated/seaborn.FacetGrid.html)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264461797,https://api.github.com/repos/pydata/xarray/issues/1148,264461797,MDEyOklzc3VlQ29tbWVudDI2NDQ2MTc5Nw==,950575,2016-12-02T14:09:37Z,2016-12-02T14:09:37Z,CONTRIBUTOR,Would it make sense to set the default to False? I believe false is used in mpl.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264457608,https://api.github.com/repos/pydata/xarray/issues/1148,264457608,MDEyOklzc3VlQ29tbWVudDI2NDQ1NzYwOA==,10050469,2016-12-02T13:49:05Z,2016-12-02T13:49:05Z,MEMBER,"Great example, thanks!
Actually this would make a good test since failing to set the new kwargs to False would raise an error. Maybe you could add this simple test [here](https://github.com/pydata/xarray/blob/master/xarray/test/test_plot.py#L918)?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264455218,https://api.github.com/repos/pydata/xarray/issues/1148,264455218,MDEyOklzc3VlQ29tbWVudDI2NDQ1NTIxOA==,7442202,2016-12-02T13:36:39Z,2016-12-02T13:40:14Z,CONTRIBUTOR,"Here is an example of a random polar plot that doesn't work without the suggested modification:
```python
import xarray
import numpy as np
from collections import OrderedDict
from datetime import datetime
# define dimensions
dims = OrderedDict([
('time', [datetime(2016,12,1,1,0,0), datetime(2016,12,1,1,20,0)]),
('location', np.arange(3)),
('frequency', np.linspace(.1, .5, 20)),
('direction', np.linspace(0., 2.*np.pi, 50)),
])
# create random data
E = np.random.rand(*[len(x) for x in dims.itervalues()])
# construct DataArray
darray = xarray.DataArray(E, dims=dims, coords=dims)
# plot data
darray.plot.pcolormesh(col='time', row='location',
subplot_kws=dict(projection='polar'),
sharex=False, sharey=False)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264405582,https://api.github.com/repos/pydata/xarray/issues/1148,264405582,MDEyOklzc3VlQ29tbWVudDI2NDQwNTU4Mg==,10050469,2016-12-02T09:00:11Z,2016-12-02T09:00:11Z,MEMBER,"Yes, this looks quite straight forward! Tests would be good but I expect this to be difficult to do in the current testing framework, so no pressure on that.
What would be nice is to have an example of your usage of FacetGrid. You can either post it here or wait until I get to add https://github.com/pydata/xarray/issues/1061 to the docs!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291
https://github.com/pydata/xarray/pull/1148#issuecomment-264266498,https://api.github.com/repos/pydata/xarray/issues/1148,264266498,MDEyOklzc3VlQ29tbWVudDI2NDI2NjQ5OA==,1217238,2016-12-01T19:18:54Z,2016-12-01T19:18:54Z,MEMBER,"This seems pretty safe to me. I think this just needs a ""what's new"" entry, though tests are also always appreciated!
@fmaussion can you take a look?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192816291