html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1147#issuecomment-267440249,https://api.github.com/repos/pydata/xarray/issues/1147,267440249,MDEyOklzc3VlQ29tbWVudDI2NzQ0MDI0OQ==,1217238,2016-12-15T20:50:17Z,2016-12-15T20:50:17Z,MEMBER,In most cases I would guess these are broken tests?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267237757,https://api.github.com/repos/pydata/xarray/issues/1147,267237757,MDEyOklzc3VlQ29tbWVudDI2NzIzNzc1Nw==,1217238,2016-12-15T04:45:17Z,2016-12-15T04:45:17Z,MEMBER,You might also add these to the API docs page and what's new. I know there has been interest in public test functions for quite some time.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267236307,https://api.github.com/repos/pydata/xarray/issues/1147,267236307,MDEyOklzc3VlQ29tbWVudDI2NzIzNjMwNw==,1217238,2016-12-15T04:30:50Z,2016-12-15T04:30:50Z,MEMBER,"No no no... Just the definitions of the methods like assertDatasetEqual on
the bass xarray TestCase class, which you can now define as aliases to your
new functions.
On Wed, Dec 14, 2016 at 8:17 PM Maximilian Roos <notifications@github.com>
wrote:

> The last thing I would do is switch the existing test methods like
> assertDatasetEqual to use these functions, just to reduce the amount of
> redundant code (and also test your new functions more extensively).
>
> All of tests? I think that's a fairly heavy lift for this PR. It also
> happens to be really tedious and unfortunately I don't think Find /
> Replace-able... If you feel strongly I'll plug in and go through though!
>
> Otherwise we can roll out over time as people write new tests
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1147#issuecomment-267234900>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1hhpkMSPNJZ4mPZ-ncrUwRBuYVfeks5rIL9ogaJpZM4LA_ql>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267216755,https://api.github.com/repos/pydata/xarray/issues/1147,267216755,MDEyOklzc3VlQ29tbWVudDI2NzIxNjc1NQ==,1217238,2016-12-15T02:10:53Z,2016-12-15T02:10:53Z,MEMBER,"This looks good to me. The last thing I would do is switch the existing test methods like `assertDatasetEqual` to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-264369143,https://api.github.com/repos/pydata/xarray/issues/1147,264369143,MDEyOklzc3VlQ29tbWVudDI2NDM2OTE0Mw==,1217238,2016-12-02T04:11:06Z,2016-12-02T04:11:06Z,MEMBER,"> Do we want separate functions for each class?

That seems like overkill -- I think one is fine.

> There's a comment or just switch to py.test and add an appropriate hook. - is that different to what's here?

I was thinking of something like [how python lets you override the message for `assert a == b`](http://doc.pytest.org/en/latest/assert.html#defining-your-own-assertion-comparison). But it actually looks like there is no suitable hook for custom explanations when using methods. `__traceback__ = False`, like you do here, is about the best you can do.

> Do we want more description for the failure, above just printing the arguments? That can also be added later

It's nice to at least print the objects on separate lines, e.g., using something like `'%r\n%r' % (a, b)` for the assert message. Otherwise multi-line reprs end up with the start of the second object on the same line as the first.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746