html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1027#issuecomment-251136291,https://api.github.com/repos/pydata/xarray/issues/1027,251136291,MDEyOklzc3VlQ29tbWVudDI1MTEzNjI5MQ==,1217238,2016-10-03T15:22:18Z,2016-10-03T15:22:18Z,MEMBER,"Thanks!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251083311,https://api.github.com/repos/pydata/xarray/issues/1027,251083311,MDEyOklzc3VlQ29tbWVudDI1MTA4MzMxMQ==,1197350,2016-10-03T11:23:57Z,2016-10-03T11:23:57Z,MEMBER,"@fmaussion it's a little more involved than that...see edited description.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251044088,https://api.github.com/repos/pydata/xarray/issues/1027,251044088,MDEyOklzc3VlQ29tbWVudDI1MTA0NDA4OA==,10050469,2016-10-03T07:36:10Z,2016-10-03T07:36:10Z,MEMBER,"Just for future readers like me: the point of this PR is to make `drop_empty_bins = False` per default, right? (not True as Stephan wrote). Maybe a new edit of @rabernat 's original post would help.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251014930,https://api.github.com/repos/pydata/xarray/issues/1027,251014930,MDEyOklzc3VlQ29tbWVudDI1MTAxNDkzMA==,1197350,2016-10-03T02:29:35Z,2016-10-03T02:29:35Z,MEMBER,"I guess it's pretty easy to just do `dropna` 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251014690,https://api.github.com/repos/pydata/xarray/issues/1027,251014690,MDEyOklzc3VlQ29tbWVudDI1MTAxNDY5MA==,1217238,2016-10-03T02:26:24Z,2016-10-03T02:26:24Z,MEMBER,"Yeah my inclination would be not to add the option at all.
On Sun, Oct 2, 2016 at 7:16 PM Ryan Abernathey notifications@github.com
wrote:

> @shoyer https://github.com/shoyer So do you want the keyword argument
> dropped altogether? Or just the default changed (as in my last commit)?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> https://github.com/pydata/xarray/pull/1027#issuecomment-251013933, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/ABKS1l-Mw7ojnUQM14ZoCVXwFtA2prn-ks5qwGV7gaJpZM4KMH6y
> .
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251013933,https://api.github.com/repos/pydata/xarray/issues/1027,251013933,MDEyOklzc3VlQ29tbWVudDI1MTAxMzkzMw==,1197350,2016-10-03T02:16:27Z,2016-10-03T02:17:24Z,MEMBER,"@shoyer So do you want the keyword argument dropped altogether? Or just the default changed (as in my last commit)?

I can imagine wanting to drop the empty bins in some cases, but not as default. So I would vote to keep the keyword argument.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861
https://github.com/pydata/xarray/pull/1027#issuecomment-251010760,https://api.github.com/repos/pydata/xarray/issues/1027,251010760,MDEyOklzc3VlQ29tbWVudDI1MTAxMDc2MA==,1217238,2016-10-03T01:33:21Z,2016-10-03T01:33:21Z,MEMBER,"Rather than adding a new keyword argument, I'm inclined to unilaterally set `drop_empty_bins=True` and treat the former behavior as a bug. I can't see many use cases for the previous behavior.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,180536861