html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/7788#issuecomment-1551677537,https://api.github.com/repos/pydata/xarray/issues/7788,1551677537,IC_kwDOAMm_X85cfLhh,30606887,2023-05-17T16:06:03Z,2023-05-17T16:06:03Z,NONE,"Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again!  ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1551638978,https://api.github.com/repos/pydata/xarray/issues/7788,1551638978,IC_kwDOAMm_X85cfCHC,2448579,2023-05-17T15:45:41Z,2023-05-17T15:45:41Z,MEMBER,"Thanks @maxhollmann I pushed a test for #2377. I see this is your first contribution to Xarray. Welcome! #1792 would be a nice contribution if you're looking for more to do ;)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1551178793,https://api.github.com/repos/pydata/xarray/issues/7788,1551178793,IC_kwDOAMm_X85cdRwp,454724,2023-05-17T10:57:05Z,2023-05-17T10:57:05Z,CONTRIBUTOR,"@dcherian Sure, done :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1550187275,https://api.github.com/repos/pydata/xarray/issues/7788,1550187275,IC_kwDOAMm_X85cZfsL,2448579,2023-05-16T18:47:27Z,2023-05-16T18:47:27Z,MEMBER,Thanks @maxhollmann can you add a note to `whats-new.rst` please?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1549984548,https://api.github.com/repos/pydata/xarray/issues/7788,1549984548,IC_kwDOAMm_X85cYuMk,454724,2023-05-16T16:21:12Z,2023-05-16T16:21:12Z,CONTRIBUTOR,"I like it, solves the concern in my previous comment as well. Updated the branch.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1545939343,https://api.github.com/repos/pydata/xarray/issues/7788,1545939343,IC_kwDOAMm_X85cJSmP,2448579,2023-05-12T15:39:24Z,2023-05-12T15:39:24Z,MEMBER,"I defer to @shoyer, the solution with `where_method` seems good to me.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1545446155,https://api.github.com/repos/pydata/xarray/issues/7788,1545446155,IC_kwDOAMm_X85cHaML,5821660,2023-05-12T09:23:13Z,2023-05-12T09:23:13Z,MEMBER,"@maxhollmann I'm sorry, I'm still finding my way into Xarray. I've taken a closer look at #2377, especially https://github.com/pydata/xarray/issues/2377#issuecomment-415074188. There @shoyer suggested to just use: ```python data = duck_array_ops.where_method(data, ~mask, fill_value) ``` instead of ```python data[mask] = fill_value ``` I've checked and it works nicely with your test. That way we would get away without the flags test and the special handling will take place in duck_array_ops. Would be great if someone can double check. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1545337724,https://api.github.com/repos/pydata/xarray/issues/7788,1545337724,IC_kwDOAMm_X85cG_t8,5821660,2023-05-12T07:59:19Z,2023-05-12T07:59:19Z,MEMBER,"@maxhollmann We might get at least some more views on this. There have been discussions on handling masked arrays and we should make sure this is exactly the solution we want to have. @dcherian This changes `as_compatible_data`. Could you please have another look here? I'm a bit unclear about the implications.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1545300010,https://api.github.com/repos/pydata/xarray/issues/7788,1545300010,IC_kwDOAMm_X85cG2gq,454724,2023-05-12T07:26:52Z,2023-05-12T07:26:52Z,CONTRIBUTOR,@kmuehlbauer Do you need any adjustments to merge this?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1527322138,https://api.github.com/repos/pydata/xarray/issues/7788,1527322138,IC_kwDOAMm_X85bCRYa,454724,2023-04-28T10:10:08Z,2023-04-28T10:10:08Z,CONTRIBUTOR,"@kmuehlbauer Okay, I got it. It only seems to happen with float arrays. I adjusted the test, and it now fails without the fix. Only tangentially related to this PR, but I noticed that `as_compatible_data` will modify the original data in this path, since asarray passes through the original and afterwards the masked values are replaced with `fill_value`. So `masked_array > some_dataarray` might modify `masked_array`. Shouldn't it default to creating a copy to prevent this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1527198919,https://api.github.com/repos/pydata/xarray/issues/7788,1527198919,IC_kwDOAMm_X85bBzTH,454724,2023-04-28T08:41:32Z,2023-04-28T08:41:32Z,CONTRIBUTOR,@kmuehlbauer For some reason I can't reproduce it anymore. I'll monitor whether it occurs again in the original situation and close this otherwise after some time.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1524805132,https://api.github.com/repos/pydata/xarray/issues/7788,1524805132,IC_kwDOAMm_X85a4q4M,5821660,2023-04-27T06:13:23Z,2023-04-27T07:19:47Z,MEMBER,"@maxhollmann I've checked and memory served well, the following issue might be related: #2377. It looks like your use-case is at least connected to @gerritholl's. It would be great if you could add your original use case (as MCVE, if possible) to get more details. A special case (masked integer arrays) is discussed in #3955. As this might give additional information, it might not exactly fit your problem.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1523837408,https://api.github.com/repos/pydata/xarray/issues/7788,1523837408,IC_kwDOAMm_X85a0-ng,454724,2023-04-26T18:01:45Z,2023-04-26T18:01:45Z,CONTRIBUTOR,"@kmuehlbauer Sure, I pushed the test as I was hoping it would work.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1523829332,https://api.github.com/repos/pydata/xarray/issues/7788,1523829332,IC_kwDOAMm_X85a08pU,5821660,2023-04-26T17:55:13Z,2023-04-26T17:55:13Z,MEMBER,"@maxhollmann I'll have a look into this, I think I've seen something like this some time ago. Maybe you can add the tests to the PR or as comment? This might get more attention and will really help to debug. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1523814515,https://api.github.com/repos/pydata/xarray/issues/7788,1523814515,IC_kwDOAMm_X85a05Bz,454724,2023-04-26T17:41:47Z,2023-04-26T17:41:47Z,CONTRIBUTOR,"Hi @kmuehlbauer, no worries! It's in draft because can't figure out how to reproduce this bug for the tests. `data[mask] = fill_value` was crashing when I tried to create a DataArray from a non-writeable MaskedArray I got via [netCDF4](https://github.com/Unidata/netcdf4-python/) from a remote source. `data = np.asarray(data, dtype=dtype)` didn't set `writeable` to `true` in that case, but it does when I create a non-writeable MaskedArray in the tests. Any ideas how to test this properly?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1523786065,https://api.github.com/repos/pydata/xarray/issues/7788,1523786065,IC_kwDOAMm_X85a0yFR,5821660,2023-04-26T17:18:44Z,2023-04-26T17:18:44Z,MEMBER,"I've marked this by accident, sorry @maxhollmann. Let us know when you feel this is ready ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501 https://github.com/pydata/xarray/pull/7788#issuecomment-1523782262,https://api.github.com/repos/pydata/xarray/issues/7788,1523782262,IC_kwDOAMm_X85a0xJ2,30606887,2023-04-26T17:15:27Z,2023-04-26T17:15:27Z,NONE,"Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. If you have questions, some answers may be found in our [contributing guidelines](http://docs.xarray.dev/en/stable/contributing.html). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1685422501