html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/917#issuecomment-254223358,https://api.github.com/repos/pydata/xarray/issues/917,254223358,MDEyOklzc3VlQ29tbWVudDI1NDIyMzM1OA==,13939,2016-10-17T14:28:23Z,2016-10-17T14:28:23Z,NONE,"Before I looked at the code I assumed it was going to convert... but that's just me! As it stands a custom encoder is needed to get a JSON dump from the output, which will be a fairly common use case for this function. See https://gist.github.com/kwilcox/c41834297b1a3b732cae3ee16621f6d0. In the least maybe a little note in the documentation on how to dump the `to_dict` output to JSON (you also need to include `decode_times=False` because datetime objects are not JSON serializable either). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,167091064 https://github.com/pydata/xarray/pull/917#issuecomment-254218699,https://api.github.com/repos/pydata/xarray/issues/917,254218699,MDEyOklzc3VlQ29tbWVudDI1NDIxODY5OQ==,13939,2016-10-17T14:11:58Z,2016-10-17T14:11:58Z,NONE,"@jsignell was the intention to have only python scalars/lists in the dictionary (no numpy generics or arrays)? Right now attribute values are not being converted and results in a mixed `dict` of the data as a list but attributes still in numpy form. Thoughts? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,167091064