html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7716#issuecomment-1510444389,https://api.github.com/repos/pydata/xarray/issues/7716,1510444389,IC_kwDOAMm_X85aB41l,306380,2023-04-16T17:57:26Z,2023-04-16T17:57:26Z,MEMBER,"That makes sense. Just following up, but this fails today:
```yaml
name: test-1
channels:
- conda-forge
dependencies:
- xarray
- pandas=2
```
It sounds like this will work itself out though and no further work here needs to be done (unless someone wants to go press some green buttons on conda-forge somewhere)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1510442337,https://api.github.com/repos/pydata/xarray/issues/7716,1510442337,IC_kwDOAMm_X85aB4Vh,14808389,2023-04-16T17:47:07Z,2023-04-16T17:51:39Z,MEMBER,"I'm on a train wifi, so not really better. However, I think this is because `xarray=2023.04.0` is not on `conda-forge`, yet (the PR to the feedstock still has to be merged), so you can't install `xarray` and `pandas=2` into the same environment. As a workaround, you can try installing `xarray` using `pip`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1510434421,https://api.github.com/repos/pydata/xarray/issues/7716,1510434421,IC_kwDOAMm_X85aB2Z1,306380,2023-04-16T17:10:12Z,2023-04-16T17:10:12Z,MEMBER,"This was the environment, solved on M1 Mac
```yaml
name: coiled
channels:
- conda-forge
- defaults
dependencies:
- python==3.10
- dask
- dask-ml
- coiled
- pyarrow
- s3fs
- matplotlib
- ipykernel
- dask-labextension
- xgboost
- pandas=2
- optuna
- xarray
- geogif
- zarr
- pip
- pip:
- git+https://github.com/optuna/optuna
```
I can try to minify this in a bit, although I'm on airport wifi right now, and it has started to kick me off, I suspect due to these sorts of activities. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1510434058,https://api.github.com/repos/pydata/xarray/issues/7716,1510434058,IC_kwDOAMm_X85aB2UK,14808389,2023-04-16T17:08:16Z,2023-04-16T17:08:16Z,MEMBER,"can you share a bit more about the environment you're trying to create? Is that by chance a `py38` environment, or does one of the libraries you're trying to install have a upper bound for `xarray`? `xarray>=2023.04.0` does not have the pin on `pandas` anymore, so you should be able to install that even if the repodata patches didn't work.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1510432559,https://api.github.com/repos/pydata/xarray/issues/7716,1510432559,IC_kwDOAMm_X85aB18v,306380,2023-04-16T17:01:50Z,2023-04-16T17:01:50Z,MEMBER,"I'm still running into this today when using only conda-forge
```
Encountered problems while solving:
- package xarray-2023.1.0-pyhd8ed1ab_0 requires pandas >=1.3,<2a0, but none of the providers can be installed
```
When I add defaults the problem goes away
```yaml
channels:
- conda-forge
- defaults
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1507391665,https://api.github.com/repos/pydata/xarray/issues/7716,1507391665,IC_kwDOAMm_X85Z2Pix,2448579,2023-04-13T17:56:33Z,2023-04-13T17:56:33Z,MEMBER,Should be fixed with the various repodata patches,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497664639,https://api.github.com/repos/pydata/xarray/issues/7716,1497664639,IC_kwDOAMm_X85ZRIx_,14808389,2023-04-05T15:16:12Z,2023-04-06T08:38:30Z,MEMBER,"CI says these are the tests we'd need to fix:
```
FAILED xarray/tests/test_coding_times.py::test_should_cftime_be_used_source_outside_range - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[360_day] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[365_day] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[366_day] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[all_leap] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[gregorian] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[julian] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[noleap] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[proleptic_gregorian] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[standard] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED xarray/tests/test_dataarray.py::TestDataArray::test_sel_float - NotImplementedError: float16 indexes are not supported
```
Edit: one more on windows:
```
FAILED xarray/tests/test_utils.py::test_maybe_coerce_to_str[1-2-expected1] - AssertionError: assert dtype('int64') == dtype('int32')
+ where dtype('int64') = Index([1, 2], dtype='int64').dtype
+ and dtype('int32') = Index([1, 2], dtype='int32').dtype
```
Edit2: the doctests also fail:
```
FAILED xarray/core/accessor_dt.py::xarray.core.accessor_dt.DatetimeAccessor
FAILED xarray/core/accessor_dt.py::xarray.core.accessor_dt.TimedeltaAccessor
FAILED xarray/core/dataarray.py::xarray.core.dataarray.DataArray.groupby
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498321082,https://api.github.com/repos/pydata/xarray/issues/7716,1498321082,IC_kwDOAMm_X85ZTpC6,6628425,2023-04-06T00:16:46Z,2023-04-06T00:16:46Z,MEMBER,Thanks @keewis -- I went ahead and added some more detailed thoughts about how to address the cftime-related failures in #7707. I can try to address those soon.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498186880,https://api.github.com/repos/pydata/xarray/issues/7716,1498186880,IC_kwDOAMm_X85ZTISA,14808389,2023-04-05T21:30:41Z,2023-04-05T21:35:25Z,MEMBER,"For `test_should_cftime_be_used_source_outside_range` and `test_to_datetimeindex_out_of_range` I'd probably use a date that is outside the `s` resolution range (not sure if that actually makes sense, though). What do you think, @spencerkclark?
For `test_maybe_coerce_to_str` I think the reason is that we use `np.array` to cast a python `int` to an array, but the default resolution is different on windows. Apparently, `pandas` still uses `int64` if constructed directly from python `int`s, but `numpy` uses `int32` on windows, and as you say `pandas` does not insist on `int64` anymore. The fix would be to explicitly specify the `dtype` in the `array` calls.
And finally, I'm not sure what to do with `test_sel_float`. Maybe we can split the monolithic test into one parametrized by `dtype` and skip the `float16` test variant for `pandas>=2.0`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498186349,https://api.github.com/repos/pydata/xarray/issues/7716,1498186349,IC_kwDOAMm_X85ZTIJt,2448579,2023-04-05T21:30:02Z,2023-04-05T21:30:02Z,MEMBER,"> I think they are all expected [pandas.pydata.org/docs/whatsnew/v2.0.0.html](https://pandas.pydata.org/docs/whatsnew/v2.0.0.html) namely
Yes they are. We just haven't had the time to fix things.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498164858,https://api.github.com/repos/pydata/xarray/issues/7716,1498164858,IC_kwDOAMm_X85ZTC56,4806877,2023-04-05T21:09:59Z,2023-04-05T21:09:59Z,CONTRIBUTOR,"In that case it could be reasonable to mimic the pattern in test_groupby and mark the failing tests with a `@pytest.mark.skipif(not has_pandas_version_two, reason=""Tests a scenario that only raises when pandas <= 2"")`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498160636,https://api.github.com/repos/pydata/xarray/issues/7716,1498160636,IC_kwDOAMm_X85ZTB38,10647082,2023-04-05T21:05:34Z,2023-04-05T21:05:34Z,CONTRIBUTOR,"> CI says these are the tests we'd need to fix:
Chiming in from the pandas side on those failures, I think they are all expected https://pandas.pydata.org/docs/whatsnew/v2.0.0.html namely
* Since pandas supports `s`, `ms` and `us` numpy datetime resolutions now, I'm guessing that's why `test_to_datetimeindex_out_of_range` and `test_should_cftime_be_used_source_outside_range` are failing
* For `test_sel_float`, `pd.Index` intentionally does not support `np.float16` as dtype anymore (we never had an indexing engine for this dtype)
* For `test_maybe_coerce_to_str`, this might be expected too as `Index` dtypes can hold `np.int32` types now","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498126625,https://api.github.com/repos/pydata/xarray/issues/7716,1498126625,IC_kwDOAMm_X85ZS5kh,13760223,2023-04-05T20:42:19Z,2023-04-05T20:42:19Z,NONE,"Eagerly awaiting a resolution to this, as the newest [Pyleoclim](https://github.com/LinkedEarth/Pyleoclim_util) release will be requiring pandas >=2.0, which will make it incompatible with xarray as things stand. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497629183,https://api.github.com/repos/pydata/xarray/issues/7716,1497629183,IC_kwDOAMm_X85ZRAH_,6628425,2023-04-05T14:54:39Z,2023-04-05T14:54:39Z,MEMBER,"The cftime-related ones are still pandas related, but hopefully should be straightforward to address.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497623839,https://api.github.com/repos/pydata/xarray/issues/7716,1497623839,IC_kwDOAMm_X85ZQ-0f,14808389,2023-04-05T14:51:16Z,2023-04-05T14:51:16Z,MEMBER,"with the merge of #7441 we should already support `pandas=2.0` on `main`. I think we can try unpinning in a PR to see how many of the errors from #7707 are related to `pandas` (none, hopefully, but I'm not sure).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497579600,https://api.github.com/repos/pydata/xarray/issues/7716,1497579600,IC_kwDOAMm_X85ZQ0BQ,1197350,2023-04-05T14:23:57Z,2023-04-05T14:23:57Z,MEMBER,Do we have a plan to support pandas 2?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1496186966,https://api.github.com/repos/pydata/xarray/issues/7716,1496186966,IC_kwDOAMm_X85ZLgBW,950575,2023-04-04T15:30:37Z,2023-04-04T15:30:37Z,CONTRIBUTOR,@dcherian do you mind taking a look at https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/426? Please check the versions patched and the applied patch! Thanks!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1496107675,https://api.github.com/repos/pydata/xarray/issues/7716,1496107675,IC_kwDOAMm_X85ZLMqb,950575,2023-04-04T14:48:55Z,2023-04-04T14:48:55Z,CONTRIBUTOR,We need to do a repodata patch for the current xarray. I'll get to it soon.,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,1654022522