html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/7707#issuecomment-1555902158,https://api.github.com/repos/pydata/xarray/issues/7707,1555902158,IC_kwDOAMm_X85cvS7O,14808389,2023-05-20T12:32:47Z,2023-05-20T15:26:43Z,MEMBER,"with #7855 and the recent change to `pint` we're finally down to just two test failures (and a whole lot of warnings): ``` xarray/tests/test_dataarray.py::TestDataArray::test_to_and_from_cdms2_sgrid: ValueError: operands could not be broadcast together with shapes (3,) (4,) xarray/tests/test_ufuncs.py::test_unary: AssertionError: assert ( is or 1.0 == 0.9999999999999999) ``` The first one looks like `cdms2` is incompatible with a change in `numpy>=1.25`. Not sure if we can do anything about that, especially since there's a big warning on the [cdms2 repo](https://github.com/CDAT/cdms) stating that the package is going to be retired / archived by the end of this year... I guess we should start thinking about removing `cdms2` support? The second looks like a precision issue, which we should be able to resolve by using `assert_allclose` instead... not sure, though, especially given numpy/numpy#23773. Otherwise we could just defer to whatever `numpy` is doing (of course, that assumes that `full_like` works properly, which might not be a good idea for a unit test): ```python @pytest.mark.parametrize( ""a"", [ xr.Variable([""x""], [0, 0]), xr.DataArray([0, 0], dims=""x""), xr.Dataset({""y"": (""x"", [0, 0])}), ], ) def test_unary(a): fill_value = np.cos(0) expected = xr.full_like(a, fill_value=fill_value, dtype=fill_value.dtype) actual = np.cos(a) assert_identical(actual, expected) ``` Edit: if relying on `full_like` turns out to be a concern, maybe we could use ""copy + assign"" instead?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1650481625 https://github.com/pydata/xarray/issues/7707#issuecomment-1536641744,https://api.github.com/repos/pydata/xarray/issues/7707,1536641744,IC_kwDOAMm_X85bl0rQ,14808389,2023-05-05T18:48:42Z,2023-05-05T18:48:42Z,MEMBER,"`pint<0.21` should work, and I'm looking into how this could be fixed, see hgrecco/pint#1660 and hgrecco/pint#1749. For the latter we might have to mark the ""pint wrapping dask"" test as requiring `pint>=0.21` and make it use an explicit registry.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1650481625 https://github.com/pydata/xarray/issues/7707#issuecomment-1510443977,https://api.github.com/repos/pydata/xarray/issues/7707,1510443977,IC_kwDOAMm_X85aB4vJ,14808389,2023-04-16T17:55:12Z,2023-04-16T17:57:23Z,MEMBER,"flaky segfaults aside, we're down to just the zarr v3 tests, a flaky `cdms2` test, and a test related to `pint` (though that one appears to be an upstream issue – not entirely sure, though).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1650481625 https://github.com/pydata/xarray/issues/7707#issuecomment-1496211311,https://api.github.com/repos/pydata/xarray/issues/7707,1496211311,IC_kwDOAMm_X85ZLl9v,14808389,2023-04-04T15:47:28Z,2023-04-04T15:47:28Z,MEMBER,"it seems the tests segfaulted again. Not sure which test exactly is causing that, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1650481625