html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7561#issuecomment-1523669010,https://api.github.com/repos/pydata/xarray/issues/7561,1523669010,IC_kwDOAMm_X85a0VgS,2448579,2023-04-26T16:00:32Z,2023-04-26T16:00:32Z,MEMBER,"I'd like to merge this soon. It's an internal refactor with no public API changes.

I think we can expose the Grouper objects publicly in a new PR","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1600382587
https://github.com/pydata/xarray/pull/7561#issuecomment-1497686846,https://api.github.com/repos/pydata/xarray/issues/7561,1497686846,IC_kwDOAMm_X85ZROM-,2448579,2023-04-05T15:30:16Z,2023-04-05T15:30:16Z,MEMBER,"Variables don't have coordinates so that won't work.

mypy is correct here, it's a bug and we don't test for grouping by index variables. A commit reverting to the old `len` check would be great here, if you have the time.

 It's not clear to me why we allow this actually. Seems like `.groupby(""DIMENSION"")` solves that use-case.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1600382587
https://github.com/pydata/xarray/pull/7561#issuecomment-1497352228,https://api.github.com/repos/pydata/xarray/issues/7561,1497352228,IC_kwDOAMm_X85ZP8gk,14371165,2023-04-05T11:47:34Z,2023-04-05T11:47:34Z,MEMBER,"I'm not sure about the rest of the errors, @dcherian. Maybe IndexVariable needs to use the DataWithCoords mixin?

```
xarray/core/groupby.py:577: error: Value of type variable ""DataAlignable"" of ""align"" cannot be ""Union[DataArray, IndexVariable]""  [type-var]
xarray/core/groupby.py:577: error: Value of type variable ""DataAlignable"" of ""align"" cannot be ""Union[Dataset, DataArray, IndexVariable]""  [type-var]
xarray/tests/test_groupby.py:55: error: List item 1 has incompatible type ""int""; expected ""slice""  [list-item]
```

https://github.com/pydata/xarray/blob/d4db16699f30ad1dc3e6861601247abf4ac96567/xarray/core/alignment.py#L581-L588

https://github.com/pydata/xarray/blob/d4db16699f30ad1dc3e6861601247abf4ac96567/xarray/core/alignment.py#L31

https://github.com/pydata/xarray/blob/d4db16699f30ad1dc3e6861601247abf4ac96567/xarray/core/common.py#L376-L377

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1600382587
https://github.com/pydata/xarray/pull/7561#issuecomment-1489663853,https://api.github.com/repos/pydata/xarray/issues/7561,1489663853,IC_kwDOAMm_X85Yyndt,2448579,2023-03-30T04:13:10Z,2023-03-30T04:13:10Z,MEMBER,@Illviljan could use some typing help here if you have the time :),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1600382587