html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7545#issuecomment-1438777540,https://api.github.com/repos/pydata/xarray/issues/7545,1438777540,IC_kwDOAMm_X85VwgDE,2448579,2023-02-21T16:34:07Z,2023-02-21T16:34:07Z,MEMBER,"I think we should raise and let the user know to provide `skipna, keep_attrs` etc. in the actual reduction method, not the groupby.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1593589979
https://github.com/pydata/xarray/issues/7545#issuecomment-1438634365,https://api.github.com/repos/pydata/xarray/issues/7545,1438634365,IC_kwDOAMm_X85Vv9F9,76110149,2023-02-21T15:01:25Z,2023-02-21T15:01:25Z,CONTRIBUTOR,Thanks @keewis -- your suggestion does what I expect.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1593589979
https://github.com/pydata/xarray/issues/7545#issuecomment-1438625180,https://api.github.com/repos/pydata/xarray/issues/7545,1438625180,IC_kwDOAMm_X85Vv62c,14808389,2023-02-21T14:55:48Z,2023-02-21T14:59:06Z,MEMBER,"It seems that `skipna` has been ignored since #2541 (more than four years ago). While that might have been unintentional at the time I don't think `resample` should have that option, so maybe we should just raise a warning like we do for `keep_attrs` and eventually remove both.
Does this do what you expect?
```python
In [2]: da.resample(time=""A-Dec"").mean(skipna=True)
Out[2]:
array([[6.5]])
Coordinates:
* value (value) int64 0
* time (time) datetime64[ns] 2022-12-31
In [3]: da.resample(time=""A-Dec"").mean(skipna=False)
Out[3]:
array([[nan]])
Coordinates:
* value (value) int64 0
* time (time) datetime64[ns] 2022-12-31
```
Edit: I don't think this is related to #6772, but I'll also have a look at what's wrong there","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1593589979