html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7521#issuecomment-1474861240,https://api.github.com/repos/pydata/xarray/issues/7521,1474861240,IC_kwDOAMm_X85X6Ji4,43316012,2023-03-18T14:08:20Z,2023-03-18T14:08:20Z,COLLABORATOR,"I guess we should revert this change and use our own definition as proposed by the numpy defs.
If I find time I'll make a new PR such that we can be independent off numpys version in this regard.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1462773338,https://api.github.com/repos/pydata/xarray/issues/7521,1462773338,IC_kwDOAMm_X85XMCZa,43316012,2023-03-09T20:44:04Z,2023-03-09T20:44:04Z,COLLABORATOR,"It seems that numpy is somewhat against this change, so maybe we are better off to restore the previous state to not have a mess with supporting different numpy versions again.
Lets keep that in mind before the next release but wait if something changes on numpys side.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1450819830,https://api.github.com/repos/pydata/xarray/issues/7521,1450819830,IC_kwDOAMm_X85WecD2,43316012,2023-03-01T20:44:52Z,2023-03-01T20:44:52Z,COLLABORATOR,"I have opened https://github.com/numpy/numpy/issues/23308
It should be an easy change on numpys side if they decide to go for it.
Only problem, we again have to special case this based on bumpy version, haha.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1450808780,https://api.github.com/repos/pydata/xarray/issues/7521,1450808780,IC_kwDOAMm_X85WeZXM,2448579,2023-03-01T20:33:36Z,2023-03-01T20:33:36Z,MEMBER,"Ugh I think I clicked merge too early.
Shall we just keep it on our end till it become public? I defer to your judgement here.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1449428744,https://api.github.com/repos/pydata/xarray/issues/7521,1449428744,IC_kwDOAMm_X85WZIcI,43316012,2023-03-01T06:31:46Z,2023-03-01T06:31:46Z,COLLABORATOR,"
> Do you know if there's a plan to make something like this public on the numpy end?
No idea, the static typing of numpy is still changing a lot and has many bugs (same with xarray, haha).
I'm sure they will make it public is we request it.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1449079384,https://api.github.com/repos/pydata/xarray/issues/7521,1449079384,IC_kwDOAMm_X85WXzJY,2448579,2023-02-28T23:23:41Z,2023-02-28T23:23:41Z,MEMBER,"Thanks @headtr1ck
Do you know if there's a plan to make something like this public on the numpy end?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1426820348,https://api.github.com/repos/pydata/xarray/issues/7521,1426820348,IC_kwDOAMm_X85VC4z8,43316012,2023-02-11T16:46:31Z,2023-02-12T14:17:33Z,COLLABORATOR,"Is it some caching issue, since this PR has been lying around for some time?
Edit: nvmd, haha. I just created it literally yesterday.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1426819173,https://api.github.com/repos/pydata/xarray/issues/7521,1426819173,IC_kwDOAMm_X85VC4hl,14371165,2023-02-11T16:42:44Z,2023-02-11T16:42:44Z,MEMBER,"```
dask-core 2023.2.0 pyhd8ed1ab_0 conda-forge
distarray 2.12.2 pyh050c7b8_4 conda-forge
distlib 0.3.6 pyhd8ed1ab_0 conda-forge
distributed 2021.4.1 py39hf3d152e_1 conda-forge
```
Yeah looks like an old version. py.typed was around september so it makes sense that part.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1426818186,https://api.github.com/repos/pydata/xarray/issues/7521,1426818186,IC_kwDOAMm_X85VC4SK,43316012,2023-02-11T16:38:20Z,2023-02-11T16:38:20Z,COLLABORATOR,"I vaguely remember seeing this error before, but no idea how it got fixed.
Maybe this run uses an older version of distributed?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1426817848,https://api.github.com/repos/pydata/xarray/issues/7521,1426817848,IC_kwDOAMm_X85VC4M4,14371165,2023-02-11T16:36:34Z,2023-02-11T16:36:34Z,MEMBER,"I don't get the error. Distributed has a py.typed file https://github.com/dask/distributed/blob/main/distributed/py.typed
And if it was py.typed issue we should have seen it in other PRs and I haven't seen one yet that has this error..
@TomNicholas added py.typed to package data, https://github.com/xarray-contrib/datatree/commit/927749a7702761491461f9bdfa8a0c1fbc244d85
But still, if distributed also needs to do this we should see this error in more PRs.
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 49.2/49.2 kB 3.6 MB/s eta 0:00:00
Collecting types-docutils
Downloading types_docutils-0.19.1.3-py3-none-any.whl (16 kB)
Installing collected packages: types-PyYAML, types-pytz, types-docutils, types-setuptools
Successfully installed types-PyYAML-6.0.12.5 types-docutils-0.19.1.3 types-pytz-2022.7.1.0 types-setuptools-67.2.0.1
xarray/tests/test_distributed.py:14: error: Skipping analyzing ""distributed"": module is installed, but missing library stubs or py.typed marker [import]
xarray/tests/test_distributed.py:21: error: Skipping analyzing ""distributed.client"": module is installed, but missing library stubs or py.typed marker [import]
xarray/tests/test_distributed.py:21: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
xarray/tests/test_distributed.py:22: error: Skipping analyzing ""distributed.utils_test"": module is installed, but missing library stubs or py.typed marker [import]
Generated Cobertura report: /home/runner/work/xarray/xarray/mypy_report/cobertura.xml
Installing missing stub packages:
/home/runner/micromamba-root/envs/xarray-tests/bin/python -m pip install types-PyYAML types-pytz types-setuptools
Generated Cobertura report: /home/runner/work/xarray/xarray/mypy_report/cobertura.xml
Found 3 errors in 1 file (checked 140 source files)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844
https://github.com/pydata/xarray/pull/7521#issuecomment-1426362452,https://api.github.com/repos/pydata/xarray/issues/7521,1426362452,IC_kwDOAMm_X85VBJBU,43316012,2023-02-10T21:23:15Z,2023-02-10T21:23:15Z,COLLABORATOR,"@Illviljan I was away for quite some time, do you have an idea what is wrong with mypy-3.9?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1580266844