html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/7439#issuecomment-1383229518,https://api.github.com/repos/pydata/xarray/issues/7439,1383229518,IC_kwDOAMm_X85ScmhO,35968931,2023-01-15T19:17:35Z,2023-01-15T19:17:35Z,MEMBER,"Thanks for these comment @paigem! It's useful to hear things that might not occur to us. Good points @Illviljan. Perhaps we should restructure to make it clear that running tests / pre-commit locally is optional, but still show people how to do it?","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1532853152 https://github.com/pydata/xarray/issues/7439#issuecomment-1383112964,https://api.github.com/repos/pydata/xarray/issues/7439,1383112964,IC_kwDOAMm_X85ScKEE,14371165,2023-01-15T10:24:55Z,2023-01-15T10:31:29Z,MEMBER,"I've found this part of the documentation a bit scary in the past because there is so much stuff to do for a simple ""typo fix"" so I welcome changes here! Nowadays, since the CI runs [pytest](https://github.com/pydata/xarray/actions/runs/3914705703/jobs/6692077250), [ASV performance benchmarks](https://github.com/pydata/xarray/actions/runs/3888041731/jobs/6634964516), [pre-commit](https://github.com/pydata/xarray/pull/7438/commits/93cd752fe58b8cd7047b15bb217e2ebbcb7a6d38) and [builds the documentation](https://xray--7438.org.readthedocs.build/en/7438/) on every PR it isn't really necessary for new contributors to get it to run locally. The only thing left is setting up a new branch with git, change the code and create a PR. If the CI fails check the details of that test, correct the code, push a new commit. Setting up git can also be scary for new users but then there is [github desktop](https://desktop.github.com/) which hides away all of that in a quite user friendly GUI. Sure, if you're doing bigger changes running the specific tests locally is probably faster but at that point you're probably a more experienced contributor anyway. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1532853152 https://github.com/pydata/xarray/issues/7439#issuecomment-1382401753,https://api.github.com/repos/pydata/xarray/issues/7439,1382401753,IC_kwDOAMm_X85SZcbZ,26591824,2023-01-13T21:18:31Z,2023-01-13T21:18:31Z,CONTRIBUTOR,"One more comment (now that my docstring PR went through): - We should include something like the following under the section [Finally, make the pull request ](https://docs.xarray.dev/en/stable/contributing.html#finally-make-the-pull-request): - ""If you have made updates to the documentation, you can see a preview of the updated docs by clicking on ""Details"" under the `docs/readthedocs.org` check near the bottom of the list of checks that run automatically when submitting a PR.""","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1532853152