html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/7391#issuecomment-1384168506,https://api.github.com/repos/pydata/xarray/issues/7391,1384168506,IC_kwDOAMm_X85SgLw6,14808389,2023-01-16T14:46:03Z,2023-01-16T14:46:03Z,MEMBER,"I guess this means that we have two options: just assume this does not cause anything else to fail to get this PR to work (but then this PR would be blocked until we fixed every use of the global `keep_attrs` in a separate PR), or we ignore `str`-valued / callable `keep_attrs` for now and merge your initial proposal. Option 2 seems easier, so I'd suggest we go with that?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1503573351 https://github.com/pydata/xarray/pull/7391#issuecomment-1378595020,https://api.github.com/repos/pydata/xarray/issues/7391,1378595020,IC_kwDOAMm_X85SK7DM,14808389,2023-01-11T11:16:02Z,2023-01-11T11:16:02Z,MEMBER,"The missing documentation for this in `apply_ufunc` is definitely an oversight, so PRs very welcome! > consider this as new feature, not just a bugfix? I always struggle with classifying changes, but I guess the more we add onto this PR, the more it becomes a new feature. > implement this for `xarray.Variable` too? probably. The only reason this is not done yet is because nobody took the time to actually do it. So, once again: PRs very welcome!","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1503573351