html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/815#issuecomment-207892482,https://api.github.com/repos/pydata/xarray/issues/815,207892482,MDEyOklzc3VlQ29tbWVudDIwNzg5MjQ4Mg==,4295853,2016-04-10T00:55:47Z,2016-04-10T00:55:47Z,CONTRIBUTOR,"My pleasure, thank you @shoyer for all the really great help designing the code and making it much better!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-207123411,https://api.github.com/repos/pydata/xarray/issues/815,207123411,MDEyOklzc3VlQ29tbWVudDIwNzEyMzQxMQ==,4295853,2016-04-07T22:43:24Z,2016-04-07T22:43:24Z,CONTRIBUTOR,"Thanks @MaximilianR and @shoyer! I think we are at the last call before the merge now.
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-205473912,https://api.github.com/repos/pydata/xarray/issues/815,205473912,MDEyOklzc3VlQ29tbWVudDIwNTQ3MzkxMg==,4295853,2016-04-04T20:09:10Z,2016-04-04T20:09:10Z,CONTRIBUTOR,"@shoyer, I believe I have addressed your comments and this should be ready to merge. Thanks!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204526977,https://api.github.com/repos/pydata/xarray/issues/815,204526977,MDEyOklzc3VlQ29tbWVudDIwNDUyNjk3Nw==,4295853,2016-04-01T19:08:19Z,2016-04-02T01:50:03Z,CONTRIBUTOR,"@shoyer, user documentation added in 96677b5846603fcd3aa5fe11e56a65482a46f856
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204574264,https://api.github.com/repos/pydata/xarray/issues/815,204574264,MDEyOklzc3VlQ29tbWVudDIwNDU3NDI2NA==,4295853,2016-04-01T21:39:13Z,2016-04-01T21:39:50Z,CONTRIBUTOR,"@shoyer, @MaximilianR, and @fmaussion this is done and I added a few more test cases with nonuniform coordinates to hopefully ensure there aren't any hidden bugs.
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204564228,https://api.github.com/repos/pydata/xarray/issues/815,204564228,MDEyOklzc3VlQ29tbWVudDIwNDU2NDIyOA==,4295853,2016-04-01T20:59:22Z,2016-04-01T20:59:22Z,CONTRIBUTOR,"@shoyer et al, I think @MaximilianR's suggestion makes sense. This would reduce the amount of code that has to be accounted for too and would be cleaner. Essentially have this method be called via `array.where(mask, drop=True)` instead of `array.sel_where(mask)`.
All feedback on this proposal welcome.
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204530971,https://api.github.com/repos/pydata/xarray/issues/815,204530971,MDEyOklzc3VlQ29tbWVudDIwNDUzMDk3MQ==,4295853,2016-04-01T19:19:35Z,2016-04-01T19:19:35Z,CONTRIBUTOR,"@shoyer, squashed the commits for simplicity.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204523177,https://api.github.com/repos/pydata/xarray/issues/815,204523177,MDEyOklzc3VlQ29tbWVudDIwNDUyMzE3Nw==,4295853,2016-04-01T18:58:45Z,2016-04-01T18:58:45Z,CONTRIBUTOR,"@shoyer, thanks for submitting the dask issue.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204513246,https://api.github.com/repos/pydata/xarray/issues/815,204513246,MDEyOklzc3VlQ29tbWVudDIwNDUxMzI0Ng==,4295853,2016-04-01T18:44:27Z,2016-04-01T18:44:27Z,CONTRIBUTOR,"@fmaussion, for
``` python
array = DataArray(np.arange(5**3).reshape(5, 5, 5), dims=('x', 'y', 'z'))
mask = DataArray(np.arange(5**2).reshape(5, 5), dims=('x', 'y'))
actual = array.sel_where(np.logical_and(mask > 6, mask < 18))
```
it returns this
``` python
(Pdb) actual
<xarray.DataArray (x: 3, y: 5, z: 5)>
array([[[ nan, nan, nan, nan, nan],
[ nan, nan, nan, nan, nan],
[ 35., 36., 37., 38., 39.],
[ 40., 41., 42., 43., 44.],
[ 45., 46., 47., 48., 49.]],
[[ 50., 51., 52., 53., 54.],
[ 55., 56., 57., 58., 59.],
[ 60., 61., 62., 63., 64.],
[ 65., 66., 67., 68., 69.],
[ 70., 71., 72., 73., 74.]],
[[ 75., 76., 77., 78., 79.],
[ 80., 81., 82., 83., 84.],
[ 85., 86., 87., 88., 89.],
[ nan, nan, nan, nan, nan],
[ nan, nan, nan, nan, nan]]])
Coordinates:
* x (x) int64 1 2 3
* y (y) int64 0 1 2 3 4
* z (z) int64 0 1 2 3 4
```
where
``` python
(Pdb) array
<xarray.DataArray (x: 5, y: 5, z: 5)>
array([[[ 0, 1, 2, 3, 4],
[ 5, 6, 7, 8, 9],
[ 10, 11, 12, 13, 14],
[ 15, 16, 17, 18, 19],
[ 20, 21, 22, 23, 24]],
[[ 25, 26, 27, 28, 29],
[ 30, 31, 32, 33, 34],
[ 35, 36, 37, 38, 39],
[ 40, 41, 42, 43, 44],
[ 45, 46, 47, 48, 49]],
[[ 50, 51, 52, 53, 54],
[ 55, 56, 57, 58, 59],
[ 60, 61, 62, 63, 64],
[ 65, 66, 67, 68, 69],
[ 70, 71, 72, 73, 74]],
[[ 75, 76, 77, 78, 79],
[ 80, 81, 82, 83, 84],
[ 85, 86, 87, 88, 89],
[ 90, 91, 92, 93, 94],
[ 95, 96, 97, 98, 99]],
[[100, 101, 102, 103, 104],
[105, 106, 107, 108, 109],
[110, 111, 112, 113, 114],
[115, 116, 117, 118, 119],
[120, 121, 122, 123, 124]]])
Coordinates:
* x (x) int64 0 1 2 3 4
* y (y) int64 0 1 2 3 4
* z (z) int64 0 1 2 3 4
```
``` python
(Pdb) np.logical_and(mask > 6, mask < 18)
<xarray.DataArray (x: 5, y: 5)>
array([[False, False, False, False, False],
[False, False, True, True, True],
[ True, True, True, True, True],
[ True, True, True, False, False],
[False, False, False, False, False]], dtype=bool)
Coordinates:
* x (x) int64 0 1 2 3 4
* y (y) int64 0 1 2 3 4
```
Is this what you were expecting?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134
https://github.com/pydata/xarray/pull/815#issuecomment-204498369,https://api.github.com/repos/pydata/xarray/issues/815,204498369,MDEyOklzc3VlQ29tbWVudDIwNDQ5ODM2OQ==,4295853,2016-04-01T18:08:46Z,2016-04-01T18:08:59Z,CONTRIBUTOR,"@shoyer, I haven't added any specific documentation to the user guide. Would you recommend doing so and if so, should this go near here https://github.com/pydata/xarray/blame/master/doc/indexing.rst#L265?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,145243134