html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/812#issuecomment-251227137,https://api.github.com/repos/pydata/xarray/issues/812,251227137,MDEyOklzc3VlQ29tbWVudDI1MTIyNzEzNw==,1217238,2016-10-03T21:06:25Z,2016-10-03T21:06:25Z,MEMBER,"Thanks! Let's see how the docs look at http://xarray.pydata.org/en/latest/whats-new.html in a few minutes after the doc build completes
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-251146483,https://api.github.com/repos/pydata/xarray/issues/812,251146483,MDEyOklzc3VlQ29tbWVudDI1MTE0NjQ4Mw==,4295853,2016-10-03T15:58:57Z,2016-10-03T15:58:57Z,CONTRIBUTOR,"@shoyer, is this what you were thinking?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-250620823,https://api.github.com/repos/pydata/xarray/issues/812,250620823,MDEyOklzc3VlQ29tbWVudDI1MDYyMDgyMw==,1217238,2016-09-29T23:28:51Z,2016-09-29T23:28:51Z,MEMBER,"Can you add a basic sanity check for `DataArray.cumsum`?

Others I think this just needs docs (on the What's New and API pages)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-250564105,https://api.github.com/repos/pydata/xarray/issues/812,250564105,MDEyOklzc3VlQ29tbWVudDI1MDU2NDEwNQ==,4295853,2016-09-29T19:16:49Z,2016-09-29T19:16:49Z,CONTRIBUTOR,"@shoyer, I think this fixes the concerns you raised including the testing.  Thanks for all the tips!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-248741868,https://api.github.com/repos/pydata/xarray/issues/812,248741868,MDEyOklzc3VlQ29tbWVudDI0ODc0MTg2OA==,1217238,2016-09-21T21:01:44Z,2016-09-21T21:01:44Z,MEMBER,"We don't need to verify that every value is exactly as expected for Dataset/DataArray, but we should verify the general API (e.g., do at least one of `cumsum`/`cumprod` and make sure the result has the right dimensions and errors when it should). See the various `test_reduce` methods in `test_dataset.py` for examples.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-248738854,https://api.github.com/repos/pydata/xarray/issues/812,248738854,MDEyOklzc3VlQ29tbWVudDI0ODczODg1NA==,4295853,2016-09-21T20:50:36Z,2016-09-21T20:50:36Z,CONTRIBUTOR,"@shoyer, this should be ready for another review.  I also tested it with this somewhat hacky code at https://gist.github.com/a329d441fe99ae342a34b1a374650138.  It may be good to get some type of test like this into the test suite.  However, the correct location for testing these methods, in general, is not transparent to me.  It doesn't look like we broadly check reduction operations with nans, e.g., `prod` outside the `test_variable.py` file.  I have made additions here but broader testing may be useful.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-248459706,https://api.github.com/repos/pydata/xarray/issues/812,248459706,MDEyOklzc3VlQ29tbWVudDI0ODQ1OTcwNg==,4295853,2016-09-20T22:51:14Z,2016-09-20T22:51:14Z,CONTRIBUTOR,"@shoyer, @jhamman, and @MaximilianR this should be ready for a preliminary review because it works.  The key thing missing is a check for dask version and potentially more testing.  Thoughts on these issues are greatly appreciated.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-248402441,https://api.github.com/repos/pydata/xarray/issues/812,248402441,MDEyOklzc3VlQ29tbWVudDI0ODQwMjQ0MQ==,4295853,2016-09-20T19:13:02Z,2016-09-20T19:13:59Z,CONTRIBUTOR,"@shoyer and @jhamman here is the general use of the cumsum and cumprod operators.  Note, I probably need to have some type of error checking for the dask version (e.g., we require a version of dask with `nancumsum`, `nanprod`, and `nancumprod`).  What is the standard way to do this?

For example, dask 0.11.0 works but dask 0.8.1 does not and returns an error.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-218446442,https://api.github.com/repos/pydata/xarray/issues/812,218446442,MDEyOklzc3VlQ29tbWVudDIxODQ0NjQ0Mg==,4295853,2016-05-11T12:37:05Z,2016-05-11T12:37:05Z,CONTRIBUTOR,"@jhamman, I need to get back to this when I can make the time but will let you know if I have more trouble.  Thanks for following up.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-218357488,https://api.github.com/repos/pydata/xarray/issues/812,218357488,MDEyOklzc3VlQ29tbWVudDIxODM1NzQ4OA==,2443309,2016-05-11T04:15:18Z,2016-05-11T04:15:18Z,MEMBER,"@pwolfram - how's this going?  Are we still stuck on the above question?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-207066906,https://api.github.com/repos/pydata/xarray/issues/812,207066906,MDEyOklzc3VlQ29tbWVudDIwNzA2NjkwNg==,4295853,2016-04-07T19:59:35Z,2016-04-07T23:00:18Z,CONTRIBUTOR,"@shoyer, it looks like I'll need to have a `_reduce_method`-like method that doesn't reduce the dimensions, e.g., https://github.com/pydata/xarray/blob/master/xarray/core/common.py#L11.  I haven't been able to get the current branch to work properly (it returns a numpy array vs xarray datatype) and seem to be something missing.  Am I on the right track that I need to add a new abstract method?  This seems overly complicated but I haven't been able to get this to work cleanly otherwise, e.g., trying things like

``` python
    f = _func_slash_method_wrapper(method, name)
    setattr(cls, name, cls._binary_op(f))
```

Some advice or help to get me out of my naivete would be greatly appreciated.  Thanks!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-204587229,https://api.github.com/repos/pydata/xarray/issues/812,204587229,MDEyOklzc3VlQ29tbWVudDIwNDU4NzIyOQ==,4295853,2016-04-01T22:07:59Z,2016-04-01T22:07:59Z,CONTRIBUTOR,"@shoyer see https://github.com/dask/dask/pull/1077 for the `nancumsum` and `nancumprod` dask PR
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-204176392,https://api.github.com/repos/pydata/xarray/issues/812,204176392,MDEyOklzc3VlQ29tbWVudDIwNDE3NjM5Mg==,1217238,2016-03-31T23:41:59Z,2016-03-31T23:41:59Z,MEMBER,"@pwolfram dask will also definitely need `nancumsum`/`nancumprod` functions. These should be quite straightforward to add though given the [existing infrastructure](https://github.com/dask/dask/blob/master/dask/array/reductions.py).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646
https://github.com/pydata/xarray/pull/812#issuecomment-203970695,https://api.github.com/repos/pydata/xarray/issues/812,203970695,MDEyOklzc3VlQ29tbWVudDIwMzk3MDY5NQ==,4295853,2016-03-31T14:44:51Z,2016-03-31T14:44:51Z,CONTRIBUTOR,"@mrocklin and @shoyer, will we need to modify the definitions for `nanprod`, `nancumsum`, and `nancumprod` in dask for this to work in multi-threaded mode?  I took a quick look and it appears they are defined https://github.com/dask/dask/blob/d82cf2ac3fa3a61912b7934afe7b2fe9e14cc4ff/dask/array/__init__.py#L17-L22 so I'm assuming xarray/dask should just work once the issues on the xarray end are resolved but just wanted to double check to make sure this is the case.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,144920646