html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7266#issuecomment-1336172648,https://api.github.com/repos/pydata/xarray/issues/7266,1336172648,IC_kwDOAMm_X85PpGBo,6628425,2022-12-03T14:36:44Z,2022-12-03T14:36:44Z,MEMBER,"As I think about this more, it wouldn't be too hard for us to support the `base` argument even after pandas removes it, so perhaps this isn't so urgent (at least as far as deprecation is concerned; we still need to make updates for compatibility, however). The code to translate a `base` argument to an `offset` argument can be found [here](https://github.com/pandas-dev/pandas/blob/bca35ff73f101b29106111703021fccc8781be7a/pandas/core/resample.py#L1668-L1678), and is all possible with public API functionality. I already did something similar for the CFTimeIndex resampling code in #7284.
Maybe you were already thinking along those lines @dcherian.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424
https://github.com/pydata/xarray/issues/7266#issuecomment-1335971694,https://api.github.com/repos/pydata/xarray/issues/7266,1335971694,IC_kwDOAMm_X85PoU9u,6628425,2022-12-02T23:56:55Z,2022-12-02T23:56:55Z,MEMBER,"Sorry I didn't get to adding the warning today. I'll try and put something together over the weekend so that it gets into the release after today's. I'm not sure exactly when pandas 2.0 will be out, but regardless I guess at least it could still be valuable for anyone who doesn't upgrade xarray and pandas at the same time.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424
https://github.com/pydata/xarray/issues/7266#issuecomment-1335139569,https://api.github.com/repos/pydata/xarray/issues/7266,1335139569,IC_kwDOAMm_X85PlJzx,6628425,2022-12-02T12:03:27Z,2022-12-02T12:04:20Z,MEMBER,"Should we add some sort of deprecation warning regarding the use of the `base` argument with future versions of pandas before the next release?
(I did not end up restoring the pandas warning in #7284)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424
https://github.com/pydata/xarray/issues/7266#issuecomment-1312768623,https://api.github.com/repos/pydata/xarray/issues/7266,1312768623,IC_kwDOAMm_X85OP0Jv,6628425,2022-11-13T16:21:28Z,2022-11-13T16:21:28Z,MEMBER,Perhaps we can at least restore the warning in #7284 in case our next release happens to take place before the next pandas release to give users somewhat of a heads up. Apologies for being a bit out of the loop of #4292 at the time.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424
https://github.com/pydata/xarray/issues/7266#issuecomment-1312767572,https://api.github.com/repos/pydata/xarray/issues/7266,1312767572,IC_kwDOAMm_X85OPz5U,6628425,2022-11-13T16:16:52Z,2022-11-13T16:16:52Z,MEMBER,"I went ahead and actually implemented the `origin` and `offset` options for the `CFTimeIndex` version of resample as part of #7284. It might be good to finish that and then we can decide how we would like to handle the deprecation.
> Maybe we should try to catch Deprecation warnings in the nightly builds and raise an error / Automatic issue, so we can fix things before they break.
I agree -- something like that would be useful in general. In this particular case it seems like we were aware of it at one point, but just lost track after silencing it initially for compatibility reasons (https://github.com/pydata/xarray/pull/4292#issuecomment-691665611). Unfortunately that means that this was silenced in user code as well.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424
https://github.com/pydata/xarray/issues/7266#issuecomment-1308705176,https://api.github.com/repos/pydata/xarray/issues/7266,1308705176,IC_kwDOAMm_X85OAUGY,6628425,2022-11-09T12:52:11Z,2022-11-09T12:53:13Z,MEMBER,"Yes, I think so too. I can look into it more this weekend. Clearly we need to change the code that relies on pandas immediately. For resampling with a `CFTimeIndex` I may create a separate issue for implementing these new arguments (we can probably get those tests passing in the meantime, however).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440280424