html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7222#issuecomment-1293689561,https://api.github.com/repos/pydata/xarray/issues/7222,1293689561,IC_kwDOAMm_X85NHCLZ,90008,2022-10-27T15:15:45Z,2022-10-27T15:15:45Z,CONTRIBUTOR,"> but that would be a lot of work especially for such a critical piece of code in Xarray.
Agreed. I'll take the small wins where I can :D.
Great! I think this will be a good addition with: https://github.com/pydata/xarray/pull/7223#discussion_r1007023769","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834
https://github.com/pydata/xarray/pull/7222#issuecomment-1291405225,https://api.github.com/repos/pydata/xarray/issues/7222,1291405225,IC_kwDOAMm_X85M-Uep,90008,2022-10-26T02:19:23Z,2022-10-26T02:19:23Z,CONTRIBUTOR,"I think the rapid return, helps by about 40% is still pretty good.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834
https://github.com/pydata/xarray/pull/7222#issuecomment-1291402576,https://api.github.com/repos/pydata/xarray/issues/7222,1291402576,IC_kwDOAMm_X85M-T1Q,90008,2022-10-26T02:17:45Z,2022-10-26T02:17:45Z,CONTRIBUTOR,hmm ok. it seems i can't blatently avoid the copy like that.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834
https://github.com/pydata/xarray/pull/7222#issuecomment-1291391647,https://api.github.com/repos/pydata/xarray/issues/7222,1291391647,IC_kwDOAMm_X85M-RKf,90008,2022-10-26T02:03:41Z,2022-10-26T02:03:41Z,CONTRIBUTOR,"The reason this is a separate merge request, is that I agree that this is more contentious as a change.
However, I will argue that `Aligner` should really not be a class.
Using ripgrep you find that the only instances of Aligner exist internally:
```
xarray/core/dataset.py
2775: aligner: alignment.Aligner,
2783: """"""Callback called from ``Aligner`` to create a new reindexed Dataset.""""""
xarray/core/alignment.py
107:class Aligner(Generic[DataAlignable]):
114: aligner = Aligner(*objects, **kwargs) <------- Example
767: aligner = Aligner( <----------- Used and consumed for the method `align`
881: aligner = Aligner( <----------- Used and consumed for the method `reindex`
909: # This check is not performed in Aligner.
xarray/core/dataarray.py
1752: aligner: alignment.Aligner,
1760: """"""Callback called from ``Aligner`` to create a new reindexed DataArray.""""""
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834