html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7221#issuecomment-1293815240,https://api.github.com/repos/pydata/xarray/issues/7221,1293815240,IC_kwDOAMm_X85NHg3I,14371165,2022-10-27T16:58:45Z,2022-10-27T16:58:45Z,MEMBER,"```
       before           after         ratio
     [c000690c]       [24753f1f]
-     3.17±0.02ms      1.94±0.01ms     0.61  merge.DatasetAddVariable.time_variable_insertion(100)
-        81.5±2ms       17.0±0.2ms     0.21  merge.DatasetAddVariable.time_variable_insertion(1000)

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.
```
Nice improvements. :)

I haven't fully understood why we had that code though?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423312198
https://github.com/pydata/xarray/pull/7221#issuecomment-1291523800,https://api.github.com/repos/pydata/xarray/issues/7221,1291523800,IC_kwDOAMm_X85M-xbY,14371165,2022-10-26T05:27:11Z,2022-10-26T05:27:11Z,MEMBER,Now the asv finishes at least! Could you make a separate PR for the asv? I don't think it runs it when comparing to the main branch.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423312198
https://github.com/pydata/xarray/pull/7221#issuecomment-1291501993,https://api.github.com/repos/pydata/xarray/issues/7221,1291501993,IC_kwDOAMm_X85M-sGp,14371165,2022-10-26T04:56:39Z,2022-10-26T04:57:37Z,MEMBER,"I like large datasets as well. I seem to remember getting caught in similar places when creating my datasets. I think I solved it by using Variable instead, does doing something like this improve the performance for you?

```python
import xarray as xr
dataset = xr.Dataset()
dataset['a'] = xr.Variable(dims=""time"", data=[1])
dataset['b'] = xr.Variable(dims=""time"", data=[2])
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423312198
https://github.com/pydata/xarray/pull/7221#issuecomment-1291493769,https://api.github.com/repos/pydata/xarray/issues/7221,1291493769,IC_kwDOAMm_X85M-qGJ,14371165,2022-10-26T04:44:43Z,2022-10-26T04:44:43Z,MEMBER,"```
Error: [ 75.90%] ··· dataset_creation.Creation.time_dataset_creation             failed
[ 75.90%] ···· asv: benchmark timed out (timeout 60.0s)
```
Maybe 1000 loops is too much. Start with 100 maybe? We still want these benchmarks to be decently fast in the CI.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423312198