html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7156#issuecomment-1277103850,https://api.github.com/repos/pydata/xarray/issues/7156,1277103850,IC_kwDOAMm_X85MHw7q,25172489,2022-10-13T06:40:59Z,2022-10-13T06:40:59Z,NONE,"This is raised by `matplotlib`, not `pandas`. Personally, I prefer aligning with upstream projects, so I'd pick that very same error.
One could argue that it's a `ValueError` in the sense that there's no data to plot, which is like an invalid value. But I also could see why they picked `TypeError`, because one could have non-numeric (but not empty) data. But yeah, this is nitpicking, I suppose 😆 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1276771566,https://api.github.com/repos/pydata/xarray/issues/7156,1276771566,IC_kwDOAMm_X85MGfzu,43316012,2022-10-12T21:49:27Z,2022-10-12T21:49:27Z,COLLABORATOR,"> pandas raises an error when plotting an empty dataframe:
>
> ```python
> ...
> TypeError: no numeric data to plot
> ```
Not sure if TypeError is correct?
Should it not be a ValueError?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1276752500,https://api.github.com/repos/pydata/xarray/issues/7156,1276752500,IC_kwDOAMm_X85MGbJ0,14371165,2022-10-12T21:24:57Z,2022-10-12T21:24:57Z,MEMBER,"pandas raises an error when plotting an empty dataframe:
```python
import pandas as pd
a = pd.DataFrame()
a.plot()
Traceback (most recent call last):
File ""C:\Users\J.W\AppData\Local\Temp\ipykernel_14580\3422621525.py"", line 1, in |
a.plot()
File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\plotting\_core.py"", line 1001, in __call__
return plot_backend.plot(data, kind=kind, **kwargs)
File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\plotting\_matplotlib\__init__.py"", line 71, in plot
plot_obj.generate()
File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\plotting\_matplotlib\core.py"", line 451, in generate
self._compute_plot_data()
File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\plotting\_matplotlib\core.py"", line 636, in _compute_plot_data
raise TypeError(""no numeric data to plot"")
TypeError: no numeric data to plot
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1276635221,https://api.github.com/repos/pydata/xarray/issues/7156,1276635221,IC_kwDOAMm_X85MF-hV,2448579,2022-10-12T19:21:00Z,2022-10-12T19:21:00Z,MEMBER,"I don't think we have a test for plotting empty DataArrays, so no combination of dependencies would've picked that up?
We should just explicitly check for `da.size > 0` before trying anything in `.plot`","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1276623786,https://api.github.com/repos/pydata/xarray/issues/7156,1276623786,IC_kwDOAMm_X85MF7uq,14808389,2022-10-12T19:11:38Z,2022-10-12T19:11:38Z,MEMBER,"the issue is that we only have a minimum dependencies CI (i.e. `pandas` and `numpy` but not `matplotlib`) and one that tests all dependencies with minimum versions. This means that we don't have an environment could have caught this (we'd need one with `matplotlib` but not `nc-time-axis`). This case is one of the issues we run into with so many optional dependencies: we can't just test every combination of them (the ""all but dask"" CI is an exception).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1276555939,https://api.github.com/repos/pydata/xarray/issues/7156,1276555939,IC_kwDOAMm_X85MFrKj,35968931,2022-10-12T18:11:52Z,2022-10-12T18:11:52Z,MEMBER,"Thanks for the bug report @derhintze !
I'm confused as to why this wasn't caught by our tests - I thought we had a minimum-dependencies test run in our suite :confused: ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1405752975
https://github.com/pydata/xarray/issues/7156#issuecomment-1275752988,https://api.github.com/repos/pydata/xarray/issues/7156,1275752988,IC_kwDOAMm_X85MCnIc,25172489,2022-10-12T08:01:31Z,2022-10-12T08:01:31Z,NONE,👁️ @headtr1ck ,"{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 2}",,1405752975
|