html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7020#issuecomment-1355725525,https://api.github.com/repos/pydata/xarray/issues/7020,1355725525,IC_kwDOAMm_X85QzrrV,43316012,2022-12-16T22:24:13Z,2022-12-16T22:24:13Z,COLLABORATOR,"Already one problem is showing from ""enforcing"" a shape property by setting is as an abstract property.
cfgrib comes with its own backend which is used instead of xarrays internal one and it is still using a shape attribute.
Anyone actually know why a abstract property cannot be fulfilled by setting an attribute? At the end I require at least a readable variable, but do not care whether it is settable or not...
Alternative:
Do not use abstract properties but the ""old-fashioned"" way of raising a NotImplementedError in the ABC instead.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1368900431
https://github.com/pydata/xarray/pull/7020#issuecomment-1355635990,https://api.github.com/repos/pydata/xarray/issues/7020,1355635990,IC_kwDOAMm_X85QzV0W,43316012,2022-12-16T21:28:18Z,2022-12-16T21:28:18Z,COLLABORATOR,"I think the implementation of a protocol for duckarrays should be done in another PR.
The mess of `ExplicitlyIndexed.__getitem__` should also be fixed in another PR, I don't feel comfortable enough yet with this part of xarray to touch things there :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1368900431
https://github.com/pydata/xarray/pull/7020#issuecomment-1244063864,https://api.github.com/repos/pydata/xarray/issues/7020,1244063864,IC_kwDOAMm_X85KJuh4,43316012,2022-09-12T17:26:06Z,2022-09-12T17:26:06Z,COLLABORATOR,"I have now removed the requirement to implement a `transpose` method as only the adapter classes implemented it but not the backend classes (it required two `# type:ignore`s...).
Maybe it would make sense to have two separate base classes for these two use cases?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1368900431
https://github.com/pydata/xarray/pull/7020#issuecomment-1243932262,https://api.github.com/repos/pydata/xarray/issues/7020,1243932262,IC_kwDOAMm_X85KJOZm,2448579,2022-09-12T15:44:18Z,2022-09-12T15:44:18Z,MEMBER,"> What is the return value of ExplicitlyIndexed.__getitem__
I think this is the mess I ran in to in a different PR: https://github.com/pydata/xarray/pull/6874#discussion_r946154605 . It's basically another `ExplicitlyIndexed` array except when it wraps a `BackendArray`, in which case you get a concrete array. IMO it should always be an `ExplicitlyIndexed` array.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 1}",,1368900431
https://github.com/pydata/xarray/pull/7020#issuecomment-1243279341,https://api.github.com/repos/pydata/xarray/issues/7020,1243279341,IC_kwDOAMm_X85KGu_t,43316012,2022-09-12T06:32:48Z,2022-09-12T06:32:48Z,COLLABORATOR,"> There's an error around the abstract transpose method, which is causing lots of tests to fail, but that aside let's merge!
I tried removing the abstract transpose method from the Baseclass but then several mypy complaints appeared.
I think one has to add overloads to `as_indexable`, which however I failed to to.
I got complaints that `np.ndarray` and `pd.Index` have overlapping types, might be a mypy bug?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1368900431
https://github.com/pydata/xarray/pull/7020#issuecomment-1243019712,https://api.github.com/repos/pydata/xarray/issues/7020,1243019712,IC_kwDOAMm_X85KFvnA,43316012,2022-09-11T18:39:53Z,2022-09-11T18:39:53Z,COLLABORATOR,"The inheritance in the indexes is quite convoluted.
Trying to fix the runtime issues concerning abstract methods missing opens another rabbit hole ...
Don't know if I can fix that without some type:ignores or Anys :/","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1368900431