html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6963#issuecomment-1322674412,https://api.github.com/repos/pydata/xarray/issues/6963,1322674412,IC_kwDOAMm_X85O1mjs,14371165,2022-11-21T21:31:48Z,2022-11-21T21:31:48Z,MEMBER,"Thanks, @lukeconibear !","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1321627289,https://api.github.com/repos/pydata/xarray/issues/6963,1321627289,IC_kwDOAMm_X85Oxm6Z,43316012,2022-11-21T08:04:26Z,2022-11-21T08:04:26Z,COLLABORATOR,"> This one throws errors still: `python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent`
> Did it ever crash if we used the normal mypy CI but with changed python version?
I don't think we ever used `--python-version` outside of this PR.
We should report this mypy bug...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1321501372,https://api.github.com/repos/pydata/xarray/issues/6963,1321501372,IC_kwDOAMm_X85OxIK8,14371165,2022-11-21T05:59:36Z,2022-11-21T05:59:36Z,MEMBER,"> > A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.
>
> So now mypy is not crashing anymore? Thats weird, we should open an issue on mypy about this...
This one throws errors still: `python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent`
Did it ever crash if we used the normal mypy CI but with changed python version?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1321250701,https://api.github.com/repos/pydata/xarray/issues/6963,1321250701,IC_kwDOAMm_X85OwK-N,43316012,2022-11-20T21:44:36Z,2022-11-20T21:44:36Z,COLLABORATOR,"> A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.
So now mypy is not crashing anymore? Thats weird, we should open an issue on mypy about this...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1321231227,https://api.github.com/repos/pydata/xarray/issues/6963,1321231227,IC_kwDOAMm_X85OwGN7,14371165,2022-11-20T20:12:00Z,2022-11-20T20:12:00Z,MEMBER,"Dask is on the ignore list:
https://github.com/pydata/xarray/blob/d6671dd414370d006254ba3156cb96256ce0e9c7/pyproject.toml#L31-L43
This seems to ignore the list and follow-imports doesn't seem to work either:
```
- name: Run mypy with python3.8
# silent all imports, since external repos might not support this
run: |
python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent
```
A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1278544017,https://api.github.com/repos/pydata/xarray/issues/6963,1278544017,IC_kwDOAMm_X85MNQiR,43316012,2022-10-14T06:29:09Z,2022-10-17T06:05:46Z,COLLABORATOR,"It seems that mypy encountered an unrecoverable runtime error.
We should probably report that to mypy, but I cannot reproduce it locally, yet alone create a MVCE.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1278199058,https://api.github.com/repos/pydata/xarray/issues/6963,1278199058,IC_kwDOAMm_X85ML8US,5635139,2022-10-13T21:29:33Z,2022-10-13T21:29:33Z,MEMBER,"I can't repro the failure on the current PR `v0.17.0-804-g7018b950`. I'm using Python 3.9 with the latest dask.
```
/home/runner/micromamba/envs/xarray-tests/lib/python3.10/site-packages/dask/utils.py:366: error: Parenthesized context managers are only supported in Python 3.9 and greater [syntax]
Found 1 error in 1 file (errors prevented further checking)
```
I'm not sure why it's raising an error for an imported module where `--follow-imports=silent`. [Isn't that supposed to suppress errors in imports](https://mypy.readthedocs.io/en/stable/running_mypy.html#follow-imports)?
And weirdly, I get errors running mypy in dask latest main, but not this error!
```
❯ mypy --python-version 3.8 .
dask/system.py:8: error: Unused ""type: ignore"" comment
dask/widgets/__init__.py:20: error: All conditional function variants must have identical signatures [misc]
dask/widgets/__init__.py:23: error: All conditional function variants must have identical signatures [misc]
dask/layers.py:1322: error: Unused ""type: ignore"" comment
dask/layers.py:1323: error: Unused ""type: ignore"" comment
dask/array/core.py:5814: error: Argument 1 to ""ndindex"" has incompatible type ""Tuple[int, ...]""; expected ""SupportsIndex"" [arg-type]
dask/array/fft.py:196: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:438: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4186: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4197: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4209: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4408: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4420: error: Unused ""type: ignore"" comment
dask/dataframe/core.py:4425: error: Unused ""type: ignore"" comment
dask/dataframe/groupby.py:1204: error: Unused ""type: ignore"" comment
dask/dataframe/io/csv.py:9: error: Unused ""type: ignore"" comment
dask/bytes/tests/test_s3.py:380: error: Unused ""type: ignore"" comment
dask/bytes/tests/test_local.py:191: error: Unused ""type: ignore"" comment
dask/bag/tests/test_text.py:33: error: Unused ""type: ignore"" comment
dask/dataframe/tests/test_shuffle.py:1408: error: Unused ""type: ignore"" comment
dask/dataframe/tests/test_shuffle.py:1409: error: Unused ""type: ignore"" comment
dask/dataframe/tests/test_shuffle.py:1412: error: Unused ""type: ignore"" comment
dask/diagnostics/tests/test_profiler.py:21: error: Unused ""type: ignore"" comment
dask/tests/test_graph_manipulation.py:106: error: ""tuple"" is not subscriptable, use ""typing.Tuple"" instead [misc]
Found 24 errors in 14 files (checked 243 source files)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1278122952,https://api.github.com/repos/pydata/xarray/issues/6963,1278122952,IC_kwDOAMm_X85MLpvI,5635139,2022-10-13T20:07:43Z,2022-10-13T20:07:43Z,MEMBER,"> Hmmm, these errors should be fixed in the latest version of this PR.
Sorry, my test was on main. I can rerun on this PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1278122387,https://api.github.com/repos/pydata/xarray/issues/6963,1278122387,IC_kwDOAMm_X85MLpmT,43316012,2022-10-13T20:07:11Z,2022-10-13T20:07:11Z,COLLABORATOR,"Hmmm, these errors should be fixed in the latest version of this PR.
The problem CI is running into is that mypy runs into an unrecoverable error parsing dask, this I cannot reproduce locally.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1278119369,https://api.github.com/repos/pydata/xarray/issues/6963,1278119369,IC_kwDOAMm_X85MLo3J,5635139,2022-10-13T20:03:50Z,2022-10-13T20:03:50Z,MEMBER,"I get some errors:
```
❯ git describe
v0.17.0-798-g3599f873
❯ mypy --python-version 3.8
xarray/core/types.py:72: error: ""tuple"" is not subscriptable [misc]
xarray/core/types.py:74: error: ""tuple"" is not subscriptable [misc]
xarray/core/types.py:76: error: ""tuple"" is not subscriptable [misc]
xarray/core/types.py:78: error: ""list"" is not subscriptable [misc]
xarray/core/_reductions.py:18: error: Cannot find implementation or library stub for module named ""flox"" [import]
xarray/core/_reductions.py:18: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
xarray/core/merge.py:43: error: ""tuple"" is not subscriptable [misc]
xarray/core/merge.py:44: error: ""tuple"" is not subscriptable [misc]
xarray/core/merge.py:45: error: ""tuple"" is not subscriptable [misc]
xarray/core/groupby.py:661: error: Cannot find implementation or library stub for module named ""flox.xarray"" [import]
xarray/backends/api.py:65: error: ""dict"" is not subscriptable [misc]
Found 10 errors in 5 files (checked 139 source files)
```
(not sure why `git describe` is showing that tag but the commit hash should repro)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277983839,https://api.github.com/repos/pydata/xarray/issues/6963,1277983839,IC_kwDOAMm_X85MLHxf,43316012,2022-10-13T18:02:19Z,2022-10-13T18:02:19Z,COLLABORATOR,"I cannot reproduce the mypy error locally.
Does this break for someone else?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277948696,https://api.github.com/repos/pydata/xarray/issues/6963,1277948696,IC_kwDOAMm_X85MK_MY,43316012,2022-10-13T17:29:09Z,2022-10-13T17:29:09Z,COLLABORATOR,"Seems like dasks typing is also not compatible with python 3.8, haha","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277933138,https://api.github.com/repos/pydata/xarray/issues/6963,1277933138,IC_kwDOAMm_X85MK7ZS,43316012,2022-10-13T17:14:44Z,2022-10-13T17:14:44Z,COLLABORATOR,"Seems that pyupgrade does not update `tuple` -> `Tuple` inside of `Union`, which is exactly what caused these problems.
Looks good to me now 👍 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277758235,https://api.github.com/repos/pydata/xarray/issues/6963,1277758235,IC_kwDOAMm_X85MKQsb,2448579,2022-10-13T15:02:13Z,2022-10-13T15:02:13Z,MEMBER,"> can we prevent that the auto labeler removes manually added labels?
no idea. cc @TomNicholas ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277754873,https://api.github.com/repos/pydata/xarray/issues/6963,1277754873,IC_kwDOAMm_X85MKP35,43316012,2022-10-13T15:00:23Z,2022-10-13T15:00:23Z,COLLABORATOR,@dcherian on a different issue: can we prevent that the auto labeler removes manually added labels?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277731299,https://api.github.com/repos/pydata/xarray/issues/6963,1277731299,IC_kwDOAMm_X85MKKHj,43316012,2022-10-13T14:44:30Z,2022-10-13T14:44:30Z,COLLABORATOR,When I run locally `mypy --python-version 3.8` i get more errors. Maybe merge current main and let's see what new issues emerge.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1277288015,https://api.github.com/repos/pydata/xarray/issues/6963,1277288015,IC_kwDOAMm_X85MId5P,43316012,2022-10-13T09:10:38Z,2022-10-13T09:10:38Z,COLLABORATOR,"Could you add an additional mypy workflow to test this behavior?
See https://github.com/pydata/xarray/issues/6962#issuecomment-1277287183","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346
https://github.com/pydata/xarray/pull/6963#issuecomment-1229559261,https://api.github.com/repos/pydata/xarray/issues/6963,1229559261,IC_kwDOAMm_X85JSZXd,43316012,2022-08-28T21:36:32Z,2022-08-28T21:36:32Z,COLLABORATOR,"That is weird, with `from __future__ import annotations` this should work.
Actually the pyupgrade pre-commit hook should even replace the typing versions by built-in versions.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1353467346