html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6910#issuecomment-1218108989,https://api.github.com/repos/pydata/xarray/issues/6910,1218108989,IC_kwDOAMm_X85Imt49,10194086,2022-08-17T14:44:58Z,2022-08-17T14:44:58Z,MEMBER,Any objections to merge this as is?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1337166287
https://github.com/pydata/xarray/pull/6910#issuecomment-1213269142,https://api.github.com/repos/pydata/xarray/issues/6910,1213269142,IC_kwDOAMm_X85IUQSW,10194086,2022-08-12T15:57:51Z,2022-08-12T15:57:51Z,MEMBER,"I also just realized, that we made many arguments keyword-only without deprecation (e.g. `xr.Dataset.mean`) - but that should not stop us from using this - there are still a lot of instances where it could be helpful.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1337166287
https://github.com/pydata/xarray/pull/6910#issuecomment-1213250165,https://api.github.com/repos/pydata/xarray/issues/6910,1213250165,IC_kwDOAMm_X85IULp1,10194086,2022-08-12T15:41:46Z,2022-08-12T15:51:24Z,MEMBER,"I just realized that there is a bug in the decorator for ""keyword-only arguments without a default"". I wonder if I should fix this or just disallow this pattern, i.e. the following does currently not work properly:

```python
@_deprecate_positional_args(""v0.1.0"")
def func(a, *, b):
    pass
```

but I am not sure how helpful it is.

EDIT: It now raises a `TypeError` for this case.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1337166287
https://github.com/pydata/xarray/pull/6910#issuecomment-1213248810,https://api.github.com/repos/pydata/xarray/issues/6910,1213248810,IC_kwDOAMm_X85IULUq,10194086,2022-08-12T15:40:46Z,2022-08-12T15:40:46Z,MEMBER,"> Are the functions you are considering using this functions that never had keyword arguments before? When I wrote a similar decorator before i had an explicit list of arguments that were allowed to be converted.

No, I want to consider arguments that have default values.

```python
def mean(dim, skipna=None, keep_attrs=None):
    pass

@_deprecate_positional_args(""v0.1.0"")
def mean(dim, *, skipna=None, keep_attrs=None):
    pass
```

Or do I missunderstand your question?

> Do you think that you can get it to work with static typing?

I think `functools.wraps` also attaches the annotations?



","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1337166287