html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6908#issuecomment-1251142486,https://api.github.com/repos/pydata/xarray/issues/6908,1251142486,IC_kwDOAMm_X85KkutW,35968931,2022-09-19T14:58:29Z,2022-09-19T14:58:55Z,MEMBER,"@Zac-HD if I could request one more review please! The two remaining problems for me are:

1) How should we alter the API of `datasets` to make it easier to construct `Dataset` objects containing duck-typed arrays (see https://github.com/pydata/xarray/pull/6908#discussion_r974066789)
2) Why does the example generation performance seem to have gotten worse? :confused: I added what I thought were small refactors (e.g. [`_sizes_from_dim_names`](https://github.com/pydata/xarray/pull/6908/files#diff-6eeb2015d4a907b3fd1ef578050a9d30971e2c1a59eec1c784bd937719478da3R353)) which may somehow be related, but I'm not sure.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1238321913,https://api.github.com/repos/pydata/xarray/issues/6908,1238321913,IC_kwDOAMm_X85Jz0r5,35968931,2022-09-06T15:38:33Z,2022-09-06T15:38:33Z,MEMBER,"It might take me a little while to get through all this, but this is a great review, thanks again @Zac-HD !","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1235820266,https://api.github.com/repos/pydata/xarray/issues/6908,1235820266,IC_kwDOAMm_X85JqR7q,35968931,2022-09-02T19:07:59Z,2022-09-02T19:07:59Z,MEMBER,@Zac-HD I think this is ready for another review (or a least a reply to the couple of unresolved comments)!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1218358572,https://api.github.com/repos/pydata/xarray/issues/6908,1218358572,IC_kwDOAMm_X85Inq0s,35968931,2022-08-17T18:30:20Z,2022-08-17T18:30:20Z,MEMBER,"Thanks for the feedback @Zac-HD, that's extremely helpful already! Sounds like we need to decide on the general API approach, then I can go back and fix all the internals.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1217246890,https://api.github.com/repos/pydata/xarray/issues/6908,1217246890,IC_kwDOAMm_X85Ijbaq,35968931,2022-08-16T22:47:42Z,2022-08-16T22:47:42Z,MEMBER,"> I'll aim for a proper review tonight!

Amazing! Thank you!

> Quick remarks: strategies accepting strategies is fine, though [our API style guide](https://github.com/HypothesisWorks/hypothesis/blob/master/guides/api-style.rst) suggests accepting strategies xor values

Oh I hadn't seen that! Looks like I independently made similar API decisions though, as far as I can tell.

","{""total_count"": 2, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1216748280,https://api.github.com/repos/pydata/xarray/issues/6908,1216748280,IC_kwDOAMm_X85Ihhr4,35968931,2022-08-16T14:52:06Z,2022-08-16T14:52:06Z,MEMBER,"@Zac-HD would you be able to give your hypothesis-expert opinions on the general design of these strategies? Especially the whole ""strategies that accept multiple other strategies"" thing.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080
https://github.com/pydata/xarray/pull/6908#issuecomment-1212153036,https://api.github.com/repos/pydata/xarray/issues/6908,1212153036,IC_kwDOAMm_X85IP_zM,35968931,2022-08-11T15:33:52Z,2022-08-11T15:33:52Z,MEMBER,I also added my chunking strategy from https://github.com/HypothesisWorks/hypothesis/issues/3433,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1336119080