html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/6891#issuecomment-1484201647,https://api.github.com/repos/pydata/xarray/issues/6891,1484201647,IC_kwDOAMm_X85Ydx6v,100865724,2023-03-26T19:40:43Z,2023-03-26T19:40:43Z,NONE,"Got it, thank you! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484199176,https://api.github.com/repos/pydata/xarray/issues/6891,1484199176,IC_kwDOAMm_X85YdxUI,43316012,2023-03-26T19:30:08Z,2023-03-26T19:30:25Z,COLLABORATOR,"As said above, you don't have to change code to make it work. The intended way of using is `da.curvefit(...., kwargs={""method"": ""trf""})`. You can submit a PR which changes **kwargs to kwargs in the docstring (both, Dataset.curvefit and DataArray.curvefit) and probably add some more info there.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484197245,https://api.github.com/repos/pydata/xarray/issues/6891,1484197245,IC_kwDOAMm_X85Ydw19,100865724,2023-03-26T19:22:17Z,2023-03-26T19:28:50Z,NONE,"@headtr1ck I tried by making some changes. There was only one function that I could find with the issue mentioned. But, I am getting some failed test cases. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484195905,https://api.github.com/repos/pydata/xarray/issues/6891,1484195905,IC_kwDOAMm_X85YdwhB,43316012,2023-03-26T19:16:38Z,2023-03-26T19:16:38Z,COLLABORATOR,"Actually, as @kmuehlbauer pointed out, we can address this for now by updating the docstring of the function. It should get clear the the extra kwargs are passed as a dict and not as **kwargs.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484188179,https://api.github.com/repos/pydata/xarray/issues/6891,1484188179,IC_kwDOAMm_X85YduoT,43316012,2023-03-26T19:02:12Z,2023-03-26T19:02:12Z,COLLABORATOR,"I think we should continue the discussion in https://github.com/pydata/xarray/issues/7130 since it is not clear which function signature (kwargs vs **kwargs) is preferred.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484185066,https://api.github.com/repos/pydata/xarray/issues/6891,1484185066,IC_kwDOAMm_X85Ydt3q,100865724,2023-03-26T18:49:38Z,2023-03-26T18:49:38Z,NONE,@TomNicholas Could you please help me out. Can I work on this issue?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1484184328,https://api.github.com/repos/pydata/xarray/issues/6891,1484184328,IC_kwDOAMm_X85YdtsI,100865724,2023-03-26T18:45:48Z,2023-03-26T18:45:48Z,NONE,"Hey! I'm an Outreachy intern, I would like to work on this issue.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1474986201,https://api.github.com/repos/pydata/xarray/issues/6891,1474986201,IC_kwDOAMm_X85X6oDZ,61923007,2023-03-18T20:37:25Z,2023-03-18T20:37:25Z,NONE,@TomNicholas I would like to work on this. Where do I start from?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1474137449,https://api.github.com/repos/pydata/xarray/issues/6891,1474137449,IC_kwDOAMm_X85X3Y1p,5821660,2023-03-17T17:03:09Z,2023-03-17T17:03:09Z,MEMBER,"Nevermind, I should read the complete issue, not only the last comment. I think this is just a problem with the doc-string then.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1474123299,https://api.github.com/repos/pydata/xarray/issues/6891,1474123299,IC_kwDOAMm_X85X3VYj,5821660,2023-03-17T16:51:49Z,2023-03-17T16:51:49Z,MEMBER,"@zoj613 Could you try to provide `kwargs=kwargs`? Where kwargs is a dict with method-key inside. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1474097791,https://api.github.com/repos/pydata/xarray/issues/6891,1474097791,IC_kwDOAMm_X85X3PJ_,44142765,2023-03-17T16:30:58Z,2023-03-17T16:31:12Z,NONE,"@alrho007 I still get this error using version `2022.9.0`: ```python In [1]: import pandas as pd [5/182] ...: import xarray as xr ...: import numpy as np ...: ...: da = xr.DataArray( ...: ...: np.random.rand(4, 3), ...: ...: [ ...: ...: (""time"", pd.date_range(""2000-01-01"", periods=4)), ...: ...: (""space"", [""IA"", ""IL"", ""IN""]), ...: ...: ], ...: ...: ) ...: da.curvefit(coords=[""time""], func=lambda x, params: x, method=""trf"") --------------------------------------------------------------------------- TypeError Traceback (most recent call last) Cell In[1], line 18 3 import numpy as np 5 da = xr.DataArray( 6 7 np.random.rand(4, 3), (...) 16 17 ) ---> 18 da.curvefit(coords=[""time""], func=lambda x, params: x, method=""trf"") TypeError: curvefit() got an unexpected keyword argument 'method' In [2]: xr.__version__ Out[2]: '2022.9.0' ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1473625704,https://api.github.com/repos/pydata/xarray/issues/6891,1473625704,IC_kwDOAMm_X85X1b5o,61923007,2023-03-17T10:30:05Z,2023-03-17T10:30:05Z,NONE,"I think this depends on the version of xarray you’re using. Newer versions from at least 0.16.0 and later now support your MVCE. If you’re still using an older version, you’ll have to pass it as dictionary elements as you said. @zoj613 @TomNicholas, you can check this out.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070 https://github.com/pydata/xarray/issues/6891#issuecomment-1208323478,https://api.github.com/repos/pydata/xarray/issues/6891,1208323478,IC_kwDOAMm_X85IBY2W,35968931,2022-08-08T16:10:17Z,2022-08-08T16:10:17Z,MEMBER,"Hi @zoj613 , thanks for the bug report. This should be a very simple fix, and your MVCE would make a great test for the behaviour. Would you be interested in contributing to xarray by submitting a PR with a fix? (No worries if you would rather we fix it, but if you are then we are always happy to welcome new contributors :grinning: )","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1331985070