html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/6845#issuecomment-1199776154,https://api.github.com/repos/pydata/xarray/issues/6845,1199776154,IC_kwDOAMm_X85HgyGa,2448579,2022-07-29T17:20:39Z,2022-07-29T17:20:39Z,MEMBER,"> My understanding is that if __array_function__ is working correctly you should never need to call cupy.round on your dataarray. Instead you should always be able to call np.round and trust that the __array_function__ implementation will dispatch to cupy's equivalent of round automatically.

:+1: Question is whether we are expected to also make `cp.round` work.

> Is there actually a case where we need the library-specific version of a numpy function to work too?

Someone's going to try it =) . At least we should document what's expected.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1321228754
https://github.com/pydata/xarray/issues/6845#issuecomment-1198619506,https://api.github.com/repos/pydata/xarray/issues/6845,1198619506,IC_kwDOAMm_X85HcXty,2448579,2022-07-28T20:51:18Z,2022-07-28T20:51:18Z,MEMBER,"> cupy.round is not supposed to be called on anything other than cupy (or numpy.ndarray

Yeah I'm not sure what the expectation is but I was calling `cp.round` on a DataArray that wrapped a cupy array. Which is why the `__array__` triggered an error. I'll update the first post to clarify.

>  my impression of __array__ is that it should only be used to convert custom objects to np.ndarray (usually using np.array or np.asarray)

OK that would suggest that the current behaviour is correct","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1321228754