html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/743#issuecomment-180097355,https://api.github.com/repos/pydata/xarray/issues/743,180097355,MDEyOklzc3VlQ29tbWVudDE4MDA5NzM1NQ==,1217238,2016-02-04T23:13:08Z,2016-02-04T23:13:08Z,MEMBER,"Looks great -- thanks! Next time, it's better to give your commits are more descriptive title, and keep GH issue numbers to the commit comments. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608 https://github.com/pydata/xarray/pull/743#issuecomment-180057047,https://api.github.com/repos/pydata/xarray/issues/743,180057047,MDEyOklzc3VlQ29tbWVudDE4MDA1NzA0Nw==,11950875,2016-02-04T21:19:27Z,2016-02-04T21:19:27Z,CONTRIBUTOR,"Hope that does it. Thanks for your help. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608 https://github.com/pydata/xarray/pull/743#issuecomment-179487814,https://api.github.com/repos/pydata/xarray/issues/743,179487814,MDEyOklzc3VlQ29tbWVudDE3OTQ4NzgxNA==,1217238,2016-02-03T21:49:21Z,2016-02-03T21:49:21Z,MEMBER,"Looks good to me, assuming tests pass. Could you please squash your commits into one? http://pandas.pydata.org/pandas-docs/stable/contributing.html#combining-commits ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608 https://github.com/pydata/xarray/pull/743#issuecomment-179485415,https://api.github.com/repos/pydata/xarray/issues/743,179485415,MDEyOklzc3VlQ29tbWVudDE3OTQ4NTQxNQ==,11950875,2016-02-03T21:42:33Z,2016-02-03T21:42:33Z,CONTRIBUTOR,"tolerance keyword is not necessary to raise this error, simply raising na from reindex operation is enough. I have changed test to reflect this, which also removes the need for pandas version checking. new test code is: ``` x = np.array([1, 2, 3], dtype=np.complex) x = xr.DataArray(x, coords=[[0.1, 0.2, 0.3]]) y = xr.DataArray([2, 5, 6, 7, 8], coords=[[-1.1, 0.21, 0.31, 0.41, 0.51]]) x.reindex_like(y, method='pad') ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608 https://github.com/pydata/xarray/pull/743#issuecomment-178993566,https://api.github.com/repos/pydata/xarray/issues/743,178993566,MDEyOklzc3VlQ29tbWVudDE3ODk5MzU2Ng==,1217238,2016-02-03T04:15:41Z,2016-02-03T04:15:41Z,MEMBER,"Could you also please add a brief change note item to `whats-new.rst` under 0.7.1? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608 https://github.com/pydata/xarray/pull/743#issuecomment-178993172,https://api.github.com/repos/pydata/xarray/issues/743,178993172,MDEyOklzc3VlQ29tbWVudDE3ODk5MzE3Mg==,1217238,2016-02-03T04:14:39Z,2016-02-03T04:14:39Z,MEMBER,"This also needs a test. I would recommend adding a regression test in `test_reindex` (https://github.com/pydata/xarray/blob/v0.7.0/xarray/test/test_dataarray.py#L622) to verify that complex valued arrays keep a complex dtype when indexed. You can use the example you provided for the github issue for this. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,130767608