html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6744#issuecomment-1183595836,https://api.github.com/repos/pydata/xarray/issues/6744,1183595836,IC_kwDOAMm_X85GjD08,43316012,2022-07-13T19:27:48Z,2022-07-13T19:27:48Z,COLLABORATOR,"We could merge this PR after a final review.
For now it fixes the bug in the issue.

For a DatasetRolling.__iter__ support we could either open a new issue or just wait until someone requests it :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752
https://github.com/pydata/xarray/pull/6744#issuecomment-1182201709,https://api.github.com/repos/pydata/xarray/issues/6744,1182201709,IC_kwDOAMm_X85Gdvdt,43316012,2022-07-12T18:26:25Z,2022-07-12T18:26:25Z,COLLABORATOR,"> Would you mind moving the first commit to a new PR that we can merge quickly please? It'll be easier to see any new tests you've added then

I'm fast in adding scope kreep xD
Done in https://github.com/pydata/xarray/pull/6777","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752
https://github.com/pydata/xarray/pull/6744#issuecomment-1175865107,https://api.github.com/repos/pydata/xarray/issues/6744,1175865107,IC_kwDOAMm_X85GFkcT,43316012,2022-07-06T07:14:24Z,2022-07-06T07:14:24Z,COLLABORATOR,Btw: this issue https://github.com/pydata/xarray/issues/6749 is the reason why it currently does not work for datasets.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752
https://github.com/pydata/xarray/pull/6744#issuecomment-1172945231,https://api.github.com/repos/pydata/xarray/issues/6744,1172945231,IC_kwDOAMm_X85F6blP,43316012,2022-07-02T18:57:56Z,2022-07-02T18:57:56Z,COLLABORATOR,"But maybe that is already too complicated.

Anyone has an idea how to get this:
```
counts = window.count(dim=self.dim[0])
window = window.where(counts >= self.min_periods)
```
operate only on variables that contain self.dim[0]?
If possible in a way that works both on DataArrays and Datasets :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752
https://github.com/pydata/xarray/pull/6744#issuecomment-1172943712,https://api.github.com/repos/pydata/xarray/issues/6744,1172943712,IC_kwDOAMm_X85F6bNg,43316012,2022-07-02T18:46:17Z,2022-07-02T18:47:55Z,COLLABORATOR,"Would it be useful to add a function `has_dim` that returns e.g.:
```
xr.DataArray([], dims=""x"").has_dim(""x"")  #-> xr.DataArray(True)
xr.Dataset({""x"": (""x"", []), ""y"": (""y"", [])}).has_dim(""x"")  # -> xr.Dataset({""x"": True, ""y"": False})
```
?
Since these are scalar (no dims) they are nicely broadcastable and can be used in xarray pipelines.

But maybe this already works easily and I just don't know about it?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752
https://github.com/pydata/xarray/pull/6744#issuecomment-1172943171,https://api.github.com/repos/pydata/xarray/issues/6744,1172943171,IC_kwDOAMm_X85F6bFD,43316012,2022-07-02T18:42:03Z,2022-07-02T18:42:03Z,COLLABORATOR,"I am now trying to get this to work for Datasets as well.
But the check of min_periods fails for variables that do not contain the rolling dim, since the count is 1.
Any idea how to solve this issue?

Is there a way to get a boolean, scalar DataArray/set that contains this information?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1292091752