html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/6665#issuecomment-1159433750,https://api.github.com/repos/pydata/xarray/issues/6665,1159433750,IC_kwDOAMm_X85FG44W,43316012,2022-06-18T10:16:46Z,2022-06-18T10:16:46Z,COLLABORATOR,"I have created https://github.com/pydata/xarray/issues/6704 and tried to copy a summary of this discussion. Feel free to continue the discussion there :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1153552538,https://api.github.com/repos/pydata/xarray/issues/6665,1153552538,IC_kwDOAMm_X85EwdCa,43316012,2022-06-13T07:07:10Z,2022-06-13T07:07:10Z,COLLABORATOR,"So, how about we leave the current implemention like it is (or merge this PR, it does not really change the core functionality). And then open another issue on how to procede with rename in light of the index refactor?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1153122466,https://api.github.com/repos/pydata/xarray/issues/6665,1153122466,IC_kwDOAMm_X85Eu0Ci,43316012,2022-06-12T10:21:09Z,2022-06-12T10:21:09Z,COLLABORATOR,"Ok I see. I hereby withdraw my comment that it will be trivial, haha.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1152891482,https://api.github.com/repos/pydata/xarray/issues/6665,1152891482,IC_kwDOAMm_X85Et7pa,43316012,2022-06-11T09:53:06Z,2022-06-11T09:53:06Z,COLLABORATOR,"I will implement a `rename_dims` method, this should be trivial. I am not sure about `rename_vars`: what should this method do with the name of the `DataArray`? Should it only rename coords or also the name? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1150704268,https://api.github.com/repos/pydata/xarray/issues/6665,1150704268,IC_kwDOAMm_X85EllqM,43316012,2022-06-09T05:59:36Z,2022-06-09T05:59:36Z,COLLABORATOR,"Honestly I am a big fan of functions that are called the same for DataArray and Dataset since this enables workflows on objects that could be either. A `rename_dims` method sounds easy to implement. The `rename_vars` does not sound extremely convincing for DataArray though. Should this rename the array and it's coords?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1150260783,https://api.github.com/repos/pydata/xarray/issues/6665,1150260783,IC_kwDOAMm_X85Ej5Yv,43316012,2022-06-08T18:37:43Z,2022-06-08T18:37:43Z,COLLABORATOR,"Now the behavior is the same as before with the only addition that one can rename the DataArray with a positional argument and its cords/dims via kwargs at the same time. I have added further tests that are a bit more expressive than before. Should be ready to merge now. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1146881160,https://api.github.com/repos/pydata/xarray/issues/6665,1146881160,IC_kwDOAMm_X85EXASI,43316012,2022-06-05T20:49:33Z,2022-06-05T20:49:33Z,COLLABORATOR,"Now that I think about it... Is it common to have the DataArray being called the same as one of its dimensions/coordinates? This might break some things. So maybe better to revert the last commit that introduced this change?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511 https://github.com/pydata/xarray/pull/6665#issuecomment-1146880695,https://api.github.com/repos/pydata/xarray/issues/6665,1146880695,IC_kwDOAMm_X85EXAK3,43316012,2022-06-05T20:46:08Z,2022-06-05T20:46:08Z,COLLABORATOR,"Mow you can also have the name of the DataArray in the rename dict. The code got a bit more complicated, lots of if-branches are slight modifications of each other, probably simplifyable.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511