html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/6624#issuecomment-1142421179,https://api.github.com/repos/pydata/xarray/issues/6624,1142421179,IC_kwDOAMm_X85EF_a7,6628425,2022-05-31T17:34:58Z,2022-05-31T17:34:58Z,MEMBER,Many thanks for restoring this functionality @headtr1ck!,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1140202248,https://api.github.com/repos/pydata/xarray/issues/6624,1140202248,IC_kwDOAMm_X85D9hsI,43316012,2022-05-28T08:04:08Z,2022-05-28T08:04:08Z,COLLABORATOR,"> 🤦🏾 the failure is because pytest is running the `xr.date_range(..., use_cftime=True)` always, ignoring the `skipif` mark. > > @headtr1ck Can you add the cftime tests as a separate test instead? This will avoid the need for a `max_computes` arg too. For the separate cftime test, apply the `requires_cftime` decorator from `tests/__init__.py` to skip when cftime is not present. Done. Seems to work :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1140140458,https://api.github.com/repos/pydata/xarray/issues/6624,1140140458,IC_kwDOAMm_X85D9Smq,2448579,2022-05-28T02:14:54Z,2022-05-28T02:14:54Z,MEMBER,"🤦🏾 the failure is because pytest is running the `xr.date_range(..., use_cftime=True)` always, ignoring the `skipif` mark. @headtr1ck Can you add the cftime tests as a separate test instead? This will avoid the need for a `max_computes` arg too. For the separate cftime test, apply the `requires_cftime` decorator from `tests/__init__.py` to skip when cftime is not present.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1140135221,https://api.github.com/repos/pydata/xarray/issues/6624,1140135221,IC_kwDOAMm_X85D9RU1,2448579,2022-05-28T01:55:52Z,2022-05-28T01:55:52Z,MEMBER,"> Is it because before only indexes were supported as coord and they are never lazy? Yes. The test failure is only because we are trying to test cftime in an environment without cftime.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1135015329,https://api.github.com/repos/pydata/xarray/issues/6624,1135015329,IC_kwDOAMm_X85DpvWh,43316012,2022-05-23T18:40:56Z,2022-05-23T18:40:56Z,COLLABORATOR,I don't understand why it is so much more complicated than before the new algo. Is it because before only indexes were supported as `coord` and they are never lazy?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1133766467,https://api.github.com/repos/pydata/xarray/issues/6624,1133766467,IC_kwDOAMm_X85Dk-dD,43316012,2022-05-21T20:49:36Z,2022-05-21T20:50:38Z,COLLABORATOR,"Maybe someone with more insight into the inners of xarray cound fix that. I get a ```ValueError: `dtype` inference failed in `map_blocks`.``` for cftime arrays with dask. Also, the part with the try-except around the compute seems strange, maybe there is an easier solution?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406 https://github.com/pydata/xarray/pull/6624#issuecomment-1133072138,https://api.github.com/repos/pydata/xarray/issues/6624,1133072138,IC_kwDOAMm_X85DiU8K,2448579,2022-05-20T16:03:26Z,2022-05-20T16:03:26Z,MEMBER,"I squash merged #6556, but you'll still need to update the `max_computes` in `raise_if_dask_computes` for cftime tests. It *should* only have to compute once.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1243123406