html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6566#issuecomment-1124342119,https://api.github.com/repos/pydata/xarray/issues/6566,1124342119,IC_kwDOAMm_X85DBBln,6213168,2022-05-11T22:12:24Z,2022-05-11T22:12:24Z,MEMBER,"> Lets skip windows for now.
>
> @crusaderky this looks weird:
>
> > For some reason counting the number of tasks in the dask graph via len(ds.**dask_graph**()) [raises an Error on Windows](https://github.com/pydata/xarray/runs/6393168006?check_suite_focus=true).
I think that's the context manager teardown, not the task counting","{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1124302215,https://api.github.com/repos/pydata/xarray/issues/6566,1124302215,IC_kwDOAMm_X85DA32H,1217238,2022-05-11T21:15:36Z,2022-05-11T21:15:36Z,MEMBER,"For whatever reason, Windows seems to be much stricter about requiring file handles to be explicitly closed. So my guess is that this could be solved by using `open_dataset()` as a context manager.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1124191155,https://api.github.com/repos/pydata/xarray/issues/6566,1124191155,IC_kwDOAMm_X85DAcuz,2448579,2022-05-11T19:10:04Z,2022-05-11T19:10:04Z,MEMBER,"Lets skip windows for now.
@crusaderky this looks weird:
> For some reason counting the number of tasks in the dask graph via len(ds.__dask_graph__()) [raises an Error on Windows](https://github.com/pydata/xarray/runs/6393168006?check_suite_focus=true).","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1124163546,https://api.github.com/repos/pydata/xarray/issues/6566,1124163546,IC_kwDOAMm_X85DAV_a,35968931,2022-05-11T18:37:24Z,2022-05-11T18:37:24Z,MEMBER,"For some reason counting the number of tasks in the dask graph via `len(ds.__dask_graph__())` [raises an Error on Windows](https://github.com/pydata/xarray/runs/6393168006?check_suite_focus=true).
```
> assert num_graph_nodes(inlined) < num_graph_nodes(not_inlined)
```
...
```
> os.unlink(fullname)
E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpnmm87jlx\\temp-415.nc'
```
I only need to do this in the test, so unless someone knows a more robust way to check the number of tasks in the task graph, I'll just add a skipif windows to the test.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1124053990,https://api.github.com/repos/pydata/xarray/issues/6566,1124053990,IC_kwDOAMm_X85C_7Pm,35968931,2022-05-11T17:31:55Z,2022-05-11T17:31:55Z,MEMBER,"We discussed this in the team meeting today.
> Questions:
>
> 1. How should I test this?
I've added a test which simply counts the number of nodes in the dask graph and checks that it is smaller when `inline_array` is True.
> 2. Should it default to False or True?
We decided False for now, and maybe switch it in a future PR
> 3. `inline_array` or `inline`? (`inline_array` doesn't really make sense for open_dataset, which . creates multiple arrays)
I'll just leave it as `inline_array` for now.
I think this can be merged?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1117499016,https://api.github.com/repos/pydata/xarray/issues/6566,1117499016,IC_kwDOAMm_X85Cm66I,2448579,2022-05-04T15:34:48Z,2022-05-04T15:34:48Z,MEMBER,@TomNicholas can you review and check that I didn't miss anything?,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1117494543,https://api.github.com/repos/pydata/xarray/issues/6566,1117494543,IC_kwDOAMm_X85Cm50P,35968931,2022-05-04T15:30:52Z,2022-05-04T15:30:52Z,MEMBER,"@dcherian thanks for the heads-up. #6559 has a recent enough version of dask, so if that gets merged then I can just pull it into this PR and avoid messing about with versions here.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1117488755,https://api.github.com/repos/pydata/xarray/issues/6566,1117488755,IC_kwDOAMm_X85Cm4Zz,2448579,2022-05-04T15:25:35Z,2022-05-04T15:25:35Z,MEMBER,"> that's actually only a few versions afterwards, so I'll try bumping the dependency in this PR.
See #6559 getting the env to work took some effort","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1117431444,https://api.github.com/repos/pydata/xarray/issues/6566,1117431444,IC_kwDOAMm_X85CmqaU,35968931,2022-05-04T14:59:44Z,2022-05-04T14:59:44Z,MEMBER,"There is [some discussion](https://github.com/dask/dask/pull/6773#issuecomment-718867003) on the dask PR that added this feature about what the default value for the flag should be. They suggest that at least for datasets opened from zarr it might always be better to `inline_array=True`. I guess we could change the default in `open_zarr`, if not in `open_dataset`?
Tagging @shoyer because he had opinions in that dask PR discussion.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1117426567,https://api.github.com/repos/pydata/xarray/issues/6566,1117426567,IC_kwDOAMm_X85CmpOH,35968931,2022-05-04T14:56:31Z,2022-05-04T14:56:31Z,MEMBER,"I think the test failure might be because our minimum dependencies CI uses `dask_core=2.30`, but the `inline_array` kwarg was added in `dask_core=2021.01.0`. That's actually only a few versions afterwards, so I'll try bumping the dependency in this PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563
https://github.com/pydata/xarray/pull/6566#issuecomment-1115292947,https://api.github.com/repos/pydata/xarray/issues/6566,1115292947,IC_kwDOAMm_X85CegUT,1197350,2022-05-02T19:46:06Z,2022-05-02T19:46:06Z,MEMBER,"Exposing this options seems like a great idea IMO.
I'm not sure the best way to test this. I think the most basic test is just to make sure the `inline=True` option gets invoked in the test suite. Going further, one could examine the dask graph to make sure inlining is actually happening, but that sounds fragile and maybe also not xarray's responsibility. Let's just make sure it gets to dask.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1223270563