html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/6528#issuecomment-1111443907,https://api.github.com/repos/pydata/xarray/issues/6528,1111443907,IC_kwDOAMm_X85CP0nD,5635139,2022-04-27T20:21:12Z,2022-04-27T20:21:12Z,MEMBER,"There was some discussion a while ago about how to handle `reduce` on things that aren't reductions. There's some overlap with https://github.com/pydata/xarray/issues/1618, and that has some links to other issues. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1217566173
https://github.com/pydata/xarray/issues/6528#issuecomment-1111392810,https://api.github.com/repos/pydata/xarray/issues/6528,1111392810,IC_kwDOAMm_X85CPoIq,2448579,2022-04-27T19:23:36Z,2022-04-27T19:23:36Z,MEMBER,"> Since cumsum is not really a reduction, should we create a new method instead of reduce? I guess it would look very similar to reduce though.

:+1: I think we should add cumsum to `generate_reductions.py`. which maybe should become `generate_aggregations.py`","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1217566173
https://github.com/pydata/xarray/issues/6528#issuecomment-1111363546,https://api.github.com/repos/pydata/xarray/issues/6528,1111363546,IC_kwDOAMm_X85CPg_a,14371165,2022-04-27T18:51:07Z,2022-04-27T18:52:26Z,MEMBER,"https://github.com/pydata/xarray/blob/7173bd3f6b76e92f77f4156236fd2b3fe546c9c2/xarray/core/dataset.py#L5239-L5240
If you comment out this if-check so it always add the variable at least the example seems to work. 

Not sure how to handle this:
* Add a new keyword argument to `reduce`? `keepcoords` or can `keepdims` be expanded to handle this as well?
* Since `cumsum` is not really a reduction, should we create a new method instead of `reduce`? I guess it would look very similar to `reduce` though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1217566173