html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/6471#issuecomment-1095932543,https://api.github.com/repos/pydata/xarray/issues/6471,1095932543,IC_kwDOAMm_X85BUpp_,35968931,2022-04-12T03:34:48Z,2022-04-12T03:34:48Z,MEMBER,Sorry @djhoese for having an itchy merge finger :sweat_smile: ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334 https://github.com/pydata/xarray/pull/6471#issuecomment-1095790236,https://api.github.com/repos/pydata/xarray/issues/6471,1095790236,IC_kwDOAMm_X85BUG6c,1828519,2022-04-12T01:38:12Z,2022-04-12T01:38:12Z,CONTRIBUTOR,"Thanks for the fix. It is always risking merging before all CI is finished, especially when code is modified.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334 https://github.com/pydata/xarray/pull/6471#issuecomment-1095570154,https://api.github.com/repos/pydata/xarray/issues/6471,1095570154,IC_kwDOAMm_X85BTRLq,5635139,2022-04-11T21:11:51Z,2022-04-11T21:11:51Z,MEMBER,"I only made suggestions for a subset of the `Number` entries. Probably we should have waited at least for the `pre-commit ci` to pass. Something I've done on my other projects is enable ""Auto-merging"", so you can hit the button and it'll merge when tests pass. Currently GH requires enumerating every check you want to require passing, which then needs to be adjusted every time the test specs change — there's no button for ""all"". But maybe we should do that.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334 https://github.com/pydata/xarray/pull/6471#issuecomment-1095564967,https://api.github.com/repos/pydata/xarray/issues/6471,1095564967,IC_kwDOAMm_X85BTP6n,5635139,2022-04-11T21:05:46Z,2022-04-11T21:05:46Z,MEMBER,"Apologies @djhoese ! Fixing in https://github.com/pydata/xarray/pull/6474. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334 https://github.com/pydata/xarray/pull/6471#issuecomment-1095537116,https://api.github.com/repos/pydata/xarray/issues/6471,1095537116,IC_kwDOAMm_X85BTJHc,1828519,2022-04-11T20:31:24Z,2022-04-11T20:34:34Z,CONTRIBUTOR,"This uses the `Number` object but never imports it and is causing CI failures on my unstable dependency environment: https://github.com/pydata/xarray/blob/ec13944bbd4022614491b6ec479ff2618da14ba8/xarray/core/dataarray.py#L1156 Not sure how the tests didn't hit this or any of the linting checks. Edit: Ah I see, the tests all failed.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334 https://github.com/pydata/xarray/pull/6471#issuecomment-1095482545,https://api.github.com/repos/pydata/xarray/issues/6471,1095482545,IC_kwDOAMm_X85BS7yx,35968931,2022-04-11T19:36:54Z,2022-04-11T19:36:54Z,MEMBER,Thanks for the rapid review @max-sixty !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1200309334