html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6403#issuecomment-1076832051,https://api.github.com/repos/pydata/xarray/issues/6403,1076832051,IC_kwDOAMm_X85ALycz,14371165,2022-03-23T21:20:54Z,2022-03-23T21:21:43Z,MEMBER,"Yes, mypy found some issues with the ordering so moving to kwargs-only was my preferred solution. 
It indeed was a breaking change but I didn't think `keep_attrs`, `axis`, etc were that popular arguments either so I was not expecting too many noticing the change, and maybe just a note in the whats new would've been sufficient.
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687
https://github.com/pydata/xarray/pull/6403#issuecomment-1076676316,https://api.github.com/repos/pydata/xarray/issues/6403,1076676316,IC_kwDOAMm_X85ALMbc,10194086,2022-03-23T18:26:35Z,2022-03-23T18:26:35Z,MEMBER,"From https://github.com/pydata/xarray/pull/5950#issuecomment-974719669

> Keyword-only and some had the 3rd position arg as `keep_attrs` and in other cases it was `axis`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687
https://github.com/pydata/xarray/pull/6403#issuecomment-1076611419,https://api.github.com/repos/pydata/xarray/issues/6403,1076611419,IC_kwDOAMm_X85AK8lb,2448579,2022-03-23T17:30:59Z,2022-03-23T17:30:59Z,MEMBER,"> We might also want to do this for [https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py](https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py?rgh-link-date=2022-03-23T17%3A29%3A01Z)

:+1: I lost track of it given that PR was open for so long. IIRC one issue is that the order of args was different forr Dataset.reduce vs DatasetGroupBy.reduce (cc @Illviljan)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687
https://github.com/pydata/xarray/pull/6403#issuecomment-1076610125,https://api.github.com/repos/pydata/xarray/issues/6403,1076610125,IC_kwDOAMm_X85AK8RN,10194086,2022-03-23T17:29:46Z,2022-03-23T17:29:46Z,MEMBER,"Sounds good - I'll add a deprecation.

We might also want to do this for https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687
https://github.com/pydata/xarray/pull/6403#issuecomment-1076609267,https://api.github.com/repos/pydata/xarray/issues/6403,1076609267,IC_kwDOAMm_X85AK8Dz,10194086,2022-03-23T17:29:01Z,2022-03-23T17:29:01Z,MEMBER,"Sounds good - I'll add a deprecation.

We might also want to do this for https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687
https://github.com/pydata/xarray/pull/6403#issuecomment-1076591151,https://api.github.com/repos/pydata/xarray/issues/6403,1076591151,IC_kwDOAMm_X85AK3ov,5635139,2022-03-23T17:13:08Z,2022-03-23T17:13:08Z,MEMBER,"This is great, thanks @mathause .

From what I've seen in the wild, I do think we're going to get some breaks on some of these without a deprecation — e.g. I've rarely seen an `n` arg used for `diff` . What are your thoughts on the link that @gcaria posted in https://github.com/pydata/xarray/issues/5531? That might do the deprecation for us.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1177919687