html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/654#issuecomment-161747978,https://api.github.com/repos/pydata/xarray/issues/654,161747978,MDEyOklzc3VlQ29tbWVudDE2MTc0Nzk3OA==,1217238,2015-12-03T19:00:54Z,2015-12-03T19:00:54Z,MEMBER,"thanks! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319 https://github.com/pydata/xarray/pull/654#issuecomment-159045769,https://api.github.com/repos/pydata/xarray/issues/654,159045769,MDEyOklzc3VlQ29tbWVudDE1OTA0NTc2OQ==,1217238,2015-11-23T19:57:37Z,2015-11-23T19:57:37Z,MEMBER,"Sorry still a few places where the terminology was mixed up. We aren't renaming the `DataArray` argument here :) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319 https://github.com/pydata/xarray/pull/654#issuecomment-158236320,https://api.github.com/repos/pydata/xarray/issues/654,158236320,MDEyOklzc3VlQ29tbWVudDE1ODIzNjMyMA==,1217238,2015-11-19T23:47:45Z,2015-11-19T23:47:45Z,MEMBER,"Thanks for the reminder -- just a few minor corrections ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319 https://github.com/pydata/xarray/pull/654#issuecomment-157136187,https://api.github.com/repos/pydata/xarray/issues/654,157136187,MDEyOklzc3VlQ29tbWVudDE1NzEzNjE4Nw==,1217238,2015-11-16T19:00:22Z,2015-11-16T19:00:22Z,MEMBER,"Yes, this is great -- thank you! I do think it would be a good idea to rename that first `Dataset` parameter to `data_vars`. That would certainly be more consistent. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319 https://github.com/pydata/xarray/pull/654#issuecomment-156014938,https://api.github.com/repos/pydata/xarray/issues/654,156014938,MDEyOklzc3VlQ29tbWVudDE1NjAxNDkzOA==,1217238,2015-11-12T06:39:38Z,2015-11-12T06:39:38Z,MEMBER,"Hmm. Maybe it _would_ be a good idea to rename `variables` to `data_vars` in the constructor. The argument name is really a relic of the old xray data model which didn't distinguish between data_vars and coords. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319 https://github.com/pydata/xarray/pull/654#issuecomment-156005389,https://api.github.com/repos/pydata/xarray/issues/654,156005389,MDEyOklzc3VlQ29tbWVudDE1NjAwNTM4OQ==,1217238,2015-11-12T05:34:20Z,2015-11-12T05:34:20Z,MEMBER,"We should document `.variables` more clearly. It is indeed the fundamental property we use under the covers, but variables in `.variables` are stored as `xray.Variable` objects which is a low level API -- hence why we point people to `.data_vars` and `.coords` instead. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,116256319