html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/6136#issuecomment-1005727954,https://api.github.com/repos/pydata/xarray/issues/6136,1005727954,IC_kwDOAMm_X8478jDS,14808389,2022-01-05T14:23:00Z,2022-01-05T14:23:27Z,MEMBER,"okay, thanks, we can take it from here. Note that we have a CI to automatically run doctests, so you could in theory push to verify changes. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1093467156 https://github.com/pydata/xarray/issues/6136#issuecomment-1005665785,https://api.github.com/repos/pydata/xarray/issues/6136,1005665785,IC_kwDOAMm_X8478T35,72647856,2022-01-05T13:01:05Z,2022-01-05T13:01:05Z,CONTRIBUTOR,"I have done an update to the docstring https://github.com/pydata/xarray/pull/6140 But note it is a minimal change rather than converting to doctest-style because I don't actually download or install xarray locally - [I'm a bot that runs on AWS lambda](https://github.com/marketplace/django-doctor) to do static analysis checks on codebases for bugs. This repo was one of the 666 repos we run against when validating testing our new checkers. As I do not have xarray setup locally I dont want to push larger code changes that have not been manually ran before I push, as there would be no confidence in the quality of the change :)","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 1}",,1093467156 https://github.com/pydata/xarray/issues/6136#issuecomment-1005527383,https://api.github.com/repos/pydata/xarray/issues/6136,1005527383,IC_kwDOAMm_X8477yFX,10194086,2022-01-05T09:40:39Z,2022-01-05T09:40:39Z,MEMBER,I updated the title of the issue to reflect the new state after #6139.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1093467156 https://github.com/pydata/xarray/issues/6136#issuecomment-1005240399,https://api.github.com/repos/pydata/xarray/issues/6136,1005240399,IC_kwDOAMm_X8476sBP,72647856,2022-01-04T23:12:42Z,2022-01-04T23:12:42Z,CONTRIBUTOR,"I will make a PR to remove the paren to make the intent clearer :+1: Regarding black: worth also considering something like [this](https://github.com/marketplace/django-doctor/) to automatically highlight issues like this during PR :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1093467156 https://github.com/pydata/xarray/issues/6136#issuecomment-1005039003,https://api.github.com/repos/pydata/xarray/issues/6136,1005039003,IC_kwDOAMm_X847562b,14808389,2022-01-04T17:49:22Z,2022-01-04T17:49:22Z,MEMBER,"this does indeed look like a typo (even though as @mathause says that value will not be checked because the absence of `data` is checked first) but in any case it *is* valid to pass a `str`: `dims=""t""`, `dims=[""t""]` and `dims=(""t"",)` mean the same thing to the `DataArray` constructor for 1D data. Maybe we should just remove the parens to make this clear? I would have hoped that `black` takes care of something like that... We also have the same issue in the docstring of `DataArray.from_dict`, which by the way would really benefit from converting the code block to a doctest-style example (it will fail right now).","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1093467156 https://github.com/pydata/xarray/issues/6136#issuecomment-1005030646,https://api.github.com/repos/pydata/xarray/issues/6136,1005030646,IC_kwDOAMm_X84754z2,10194086,2022-01-04T17:38:07Z,2022-01-04T17:38:07Z,MEMBER,"This tests checks if the appropriate error is raised if the passed `dict` misses the key `""data""`. So it does IMHO not really matter what is passed as dims.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1093467156