html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/6102#issuecomment-1003563370,https://api.github.com/repos/pydata/xarray/issues/6102,1003563370,IC_kwDOAMm_X8470Slq,1562854,2022-01-01T14:02:31Z,2022-01-01T14:02:31Z,CONTRIBUTOR,Sure see https://github.com/pydata/xarray/pull/6128,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1003558676,https://api.github.com/repos/pydata/xarray/issues/6102,1003558676,IC_kwDOAMm_X8470RcU,14371165,2022-01-01T13:21:59Z,2022-01-01T13:21:59Z,MEMBER,Do you have an easy test in mind?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1003558439,https://api.github.com/repos/pydata/xarray/issues/6102,1003558439,IC_kwDOAMm_X8470RYn,1562854,2022-01-01T13:20:08Z,2022-01-01T13:20:08Z,CONTRIBUTOR,"BTW, maybe you could/should add a test for this behaviour? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1003558389,https://api.github.com/repos/pydata/xarray/issues/6102,1003558389,IC_kwDOAMm_X8470RX1,1562854,2022-01-01T13:19:39Z,2022-01-01T13:19:39Z,CONTRIBUTOR,"I checked the code from above, and it has the Matplotlib unit handlers rather than the pandas","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1002821270,https://api.github.com/repos/pydata/xarray/issues/6102,1002821270,IC_kwDOAMm_X847xdaW,2448579,2021-12-30T00:13:35Z,2021-12-30T00:13:35Z,MEMBER,"> whether xarray wants to use the pandas or matplotlib converters.
IMO matplotlib is fine
This code is from before matplotlib supported datetime64.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1002699860,https://api.github.com/repos/pydata/xarray/issues/6102,1002699860,IC_kwDOAMm_X847w_xU,1562854,2021-12-29T17:25:01Z,2021-12-29T17:25:01Z,CONTRIBUTOR,"As I'm away from a computer for a few days so can't double check, but I did bisect the problem to the pr that was reverted.
However you could keep this open for a more fulsome discussion of date handling and whether xarray wants to use the pandas or matplotlib converters. I would actually be pretty happy if pandas also just used matplotlibs converters - we already jump through some hoops to make data frames work. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1002678138,https://api.github.com/repos/pydata/xarray/issues/6102,1002678138,IC_kwDOAMm_X847w6d6,2448579,2021-12-29T16:33:58Z,2021-12-29T16:33:58Z,MEMBER,So is #6109 enough to permanently fix this?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1000322721,https://api.github.com/repos/pydata/xarray/issues/6102,1000322721,IC_kwDOAMm_X847n7ah,14371165,2021-12-23T13:57:35Z,2021-12-23T13:57:35Z,MEMBER,"There's a pr for reverting, #6064, for a separate reason that we probably should merge soon.
I simply don't understand what that registration does, it might well be just a quick fix in a time when mpl didn't support datetimes and it might be good idea to simplify and remove it in a future pr.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1000287742,https://api.github.com/repos/pydata/xarray/issues/6102,1000287742,IC_kwDOAMm_X847ny3-,1562854,2021-12-23T13:00:28Z,2021-12-23T13:00:28Z,CONTRIBUTOR,"Hi @Illviljan that is correct. However after https://github.com/pydata/xarray/pull/5794 xarray is more aggressively making the pandas choice for the user.
I'll play with it a bit to see if just removing your explicit registration fixes the problem. However changing the datetime converter would be a breaking change (to your plotting) that I'm not sure you want.
This is a tricky problem that I'm not sure matplotlib has handled properly (full disclosure, I'm on the mpl dev team and usually handle datetime issues, though I didn't design our units registry). Having a registry that users can change is very flexible. However when downstream libraries like xarray or pandas affect user plotting just by importing the package, it leads to considerable confusion as users don't necessarily know this has happened or how to get back to the Matplotlib default. Particularly if they are not using the package's plotting utilities, but just the other features and/or data types (for instance I love xarray and use it all the time in my data analysis, but I rarely use the plotting convenience functions)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812
https://github.com/pydata/xarray/issues/6102#issuecomment-1000133347,https://api.github.com/repos/pydata/xarray/issues/6102,1000133347,IC_kwDOAMm_X847nNLj,14371165,2021-12-23T08:35:17Z,2021-12-23T08:35:17Z,MEMBER,"The registration happens here, added in #1669 in 2017:
https://github.com/pydata/xarray/blob/5e8de55321171f95ed9684c33aa47112bb2519ac/xarray/plot/utils.py#L34-L39
Is the registration even needed anymore I wonder? Matplotlib started supporting datetime64 in 2018: https://github.com/matplotlib/matplotlib/releases/tag/v2.2.0
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1087126812