html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6096#issuecomment-1028303595,https://api.github.com/repos/pydata/xarray/issues/6096,1028303595,IC_kwDOAMm_X849Sqrr,14808389,2022-02-02T19:54:40Z,2022-02-02T19:54:40Z,MEMBER,"and we don't need `packaging` to *build* the package itself (e.g. the wheel), which is why we don't list it in `pyproject.toml`","{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1028301979,https://api.github.com/repos/pydata/xarray/issues/6096,1028301979,IC_kwDOAMm_X849SqSb,2443309,2022-02-02T19:52:31Z,2022-02-02T19:52:31Z,MEMBER,@ax3l - The `packaging` dependency should be resolved in https://github.com/pydata/xarray/pull/6207.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1028297799,https://api.github.com/repos/pydata/xarray/issues/6096,1028297799,IC_kwDOAMm_X849SpRH,1353258,2022-02-02T19:46:53Z,2022-02-02T19:46:53Z,NONE,"Don't you need to add [packaging](https://github.com/pypa/packaging) to your `pyproject.toml` in the
```toml
[build-system]
requires = [
]
```
section?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1000865482,https://api.github.com/repos/pydata/xarray/issues/6096,1000865482,IC_kwDOAMm_X847p_7K,10194086,2021-12-24T14:51:01Z,2021-12-24T14:51:01Z,MEMBER,Thanks for the feedback!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1000384550,https://api.github.com/repos/pydata/xarray/issues/6096,1000384550,IC_kwDOAMm_X847oKgm,10194086,2021-12-23T15:41:46Z,2021-12-23T15:41:46Z,MEMBER,:+1: thanks! I'll update the PR.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1000381435,https://api.github.com/repos/pydata/xarray/issues/6096,1000381435,IC_kwDOAMm_X847oJv7,14075922,2021-12-23T15:35:51Z,2021-12-23T15:35:51Z,NONE,"`parse` was designed to be more resilient and produce `LegacyVersion` instances for packages that didn't use sane version strings. This functionality is going away because packaging devs judged that it causes more harm than good. In practice it seems that the Python landscape is now mature for this change, as sane version number schemes appear to be extremely dominant.
So unless you know that you're parsing version numbers from packages that don't work with the plain `Version` class I don't think there's any reason to use `parse` now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1000373371,https://api.github.com/repos/pydata/xarray/issues/6096,1000373371,IC_kwDOAMm_X847oHx7,10194086,2021-12-23T15:22:12Z,2021-12-23T15:22:12Z,MEMBER,"> Note that `packaging.version.parse` will soon be effectively the same as calling `packaging.version.Version`
Actually, I would prefer `Version(xr.__version__) > Version(""0.20.1"")` over `version.parse(xr.__version__) > version.parse(""0.20.1"")` (mostly because I think it looks better...). However, it doesn't seem that this PR will be merged soon, though... Do you know if there any good reason for us to use `parse` over `Version`?
---
And I should still figure out if `DuckArrayModule(""pint"").duck_array_version` is used/ public.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-1000339097,https://api.github.com/repos/pydata/xarray/issues/6096,1000339097,IC_kwDOAMm_X847n_aZ,14075922,2021-12-23T14:24:35Z,2021-12-23T14:24:35Z,NONE,"Note that `packaging.version.parse` will soon be effectively the same as calling `packaging.version.Version`, see https://github.com/pypa/packaging/pull/407/files
You might want to instantiate `Version` explicitly to avoid confusion in the future.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755
https://github.com/pydata/xarray/pull/6096#issuecomment-999204074,https://api.github.com/repos/pydata/xarray/issues/6096,999204074,IC_kwDOAMm_X847jqTq,5635139,2021-12-22T01:10:16Z,2021-12-22T01:10:16Z,MEMBER,"Thanks @mathause !
The current `version.parse` looks good (but the others are fine if you prefer ofc)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1086346755