html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/580#issuecomment-141480082,https://api.github.com/repos/pydata/xarray/issues/580,141480082,MDEyOklzc3VlQ29tbWVudDE0MTQ4MDA4Mg==,1217238,2015-09-18T15:15:39Z,2015-09-18T15:15:39Z,MEMBER,"Yep, looks good to me. Feel free to merge when you're ready.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,106886175
https://github.com/pydata/xarray/pull/580#issuecomment-141474949,https://api.github.com/repos/pydata/xarray/issues/580,141474949,MDEyOklzc3VlQ29tbWVudDE0MTQ3NDk0OQ==,2443309,2015-09-18T14:53:51Z,2015-09-18T14:53:51Z,MEMBER,"Thanks, that fixed it. I wasn't aware we had other datastore tests in `test_conventions.py`. Now I know.
It looks like I've hit all your previous comments.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,106886175
https://github.com/pydata/xarray/pull/580#issuecomment-141350728,https://api.github.com/repos/pydata/xarray/issues/580,141350728,MDEyOklzc3VlQ29tbWVudDE0MTM1MDcyOA==,1217238,2015-09-18T05:38:34Z,2015-09-18T05:38:34Z,MEMBER,"The failing test case is on a generic CFEncodedDataStore test, which actually doesn't use `to_netcdf` to roundtrip the data:
https://github.com/xray/xray/blob/c13ee9875b31dceb505b4aead83272fbcbeef27e/xray/test/test_conventions.py#L541
I would simply special case that test on that object because it isn't relevant, e.g., on the `TestCFEncodedDataStore` object, add a method:
```
def test_invalid_dataarray_names_raise(self):
pass
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,106886175
https://github.com/pydata/xarray/pull/580#issuecomment-141344086,https://api.github.com/repos/pydata/xarray/issues/580,141344086,MDEyOklzc3VlQ29tbWVudDE0MTM0NDA4Ng==,2443309,2015-09-18T04:54:34Z,2015-09-18T04:54:34Z,MEMBER,"@shoyer - can you take a look at these failing tests and see if you can tell which backend is causing the failure? I'm a bit confused on why it isn't getting caught by my `_validate_dataset_names` function in `to_netcdf`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,106886175