html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6037#issuecomment-1013720993,https://api.github.com/repos/pydata/xarray/issues/6037,1013720993,IC_kwDOAMm_X848bCeh,5635139,2022-01-15T17:28:08Z,2022-01-15T17:28:08Z,MEMBER,Thank you @antscloud !,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,1068680815
https://github.com/pydata/xarray/pull/6037#issuecomment-1013689588,https://api.github.com/repos/pydata/xarray/issues/6037,1013689588,IC_kwDOAMm_X848a6z0,14371165,2022-01-15T14:16:00Z,2022-01-15T14:16:00Z,MEMBER,"`Number` is apparently a no-go for `int` and `float` when type checking.
For a future PR, but I don't think `.sel` is being type-checked properly in tests either as it uses Number as well:
https://github.com/pydata/xarray/blob/4c865d607e6e03605b7050d9fb6991e86346bf08/xarray/core/dataset.py#L2446
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1068680815
https://github.com/pydata/xarray/pull/6037#issuecomment-1013669587,https://api.github.com/repos/pydata/xarray/issues/6037,1013669587,IC_kwDOAMm_X848a17T,14371165,2022-01-15T11:57:18Z,2022-01-15T11:57:18Z,MEMBER,"Some typing errors now pop up now, now that we're testing it. Probably easier to use int and float instead?
```
xarray/tests/test_dataarray.py:1534: error: Argument ""tolerance"" to ""reindex"" of ""DataArray"" has incompatible type ""float""; expected ""Union[Number, Iterable[Number], None]"" [arg-type]
xarray/tests/test_dataarray.py:1538: error: List item 0 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataarray.py:1538: error: List item 1 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataarray.py:1538: error: List item 2 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1893: error: Argument ""tolerance"" to ""reindex"" of ""Dataset"" has incompatible type ""float""; expected ""Union[Number, Iterable[Number], None]"" [arg-type]
xarray/tests/test_dataset.py:1897: error: List item 0 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1897: error: List item 1 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1897: error: List item 2 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1901: error: List item 0 has incompatible type ""int""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1901: error: List item 1 has incompatible type ""float""; expected ""Number"" [list-item]
xarray/tests/test_dataset.py:1901: error: List item 2 has incompatible type ""int""; expected ""Number"" [list-item]
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1068680815
https://github.com/pydata/xarray/pull/6037#issuecomment-1006718772,https://api.github.com/repos/pydata/xarray/issues/6037,1006718772,IC_kwDOAMm_X848AU80,14371165,2022-01-06T16:18:53Z,2022-01-06T16:18:53Z,MEMBER,"```python
def test_reindex_method(self) -> None:
```
Should do the trick.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1068680815
https://github.com/pydata/xarray/pull/6037#issuecomment-1006701763,https://api.github.com/repos/pydata/xarray/issues/6037,1006701763,IC_kwDOAMm_X848AQzD,57914115,2022-01-06T15:56:24Z,2022-01-06T15:56:24Z,CONTRIBUTOR,"Thank you too for your patience
@max-sixty I don't understand where to put the `-> None`
In the test function ?
https://github.com/pydata/xarray/blob/118a00b1233db34fe90072ed2e21501337b04b35/xarray/tests/test_dataset.py#L1886
How does mypy can test these types ? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1068680815
https://github.com/pydata/xarray/pull/6037#issuecomment-1000497595,https://api.github.com/repos/pydata/xarray/issues/6037,1000497595,IC_kwDOAMm_X847omG7,5635139,2021-12-23T19:52:54Z,2021-12-23T19:52:54Z,MEMBER,"Thanks a lot!
On the relevant test, could we please add `-> None` to the `def`? That will cause mypy to use the test to check the types.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1068680815