html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5984#issuecomment-983747745,https://api.github.com/repos/pydata/xarray/issues/5984,983747745,IC_kwDOAMm_X846osyh,10194086,2021-12-01T15:22:27Z,2021-12-01T15:22:27Z,MEMBER,"Any objections to merging this as is? If we don't disallow `xr.DataArray(da)` this is a clear advantage over the current version.

However, 

```python
xr.DataArray(da).data is da.data # True
xr.DataArray(da.data).data is da.data # True
# while
da.copy().data is da.data # False (deep=True is the default)
```
might just be surprising in some situations.


(Just for completeness - `xr.DataArray(da, **kwargs)` does a good job at erroring if the `kwargs` are not compatible with `da`.)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1052740367
https://github.com/pydata/xarray/pull/5984#issuecomment-979096277,https://api.github.com/repos/pydata/xarray/issues/5984,979096277,IC_kwDOAMm_X846W9LV,10194086,2021-11-25T11:02:18Z,2021-11-25T11:02:18Z,MEMBER,"> How about we raise DeprecationWarning for now asking the user to pass in `.data` instead.

Makes sense - how about:

```python
msg = (
    ""Passing a `DataArray` object to the `DataArray` constructor is ambiguous.\n""
    ""Pass `da.data`, or use `da.copy(deep=True)`, or one of the `xarray.*_like` (e.g. ""
    ""`xarray.zeros_like`) functions instead,\n""
    ""depending on your use case.""
)
warnings.warn(msg, FutureWarning)
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1052740367
https://github.com/pydata/xarray/pull/5984#issuecomment-977689446,https://api.github.com/repos/pydata/xarray/issues/5984,977689446,IC_kwDOAMm_X846Rltm,10194086,2021-11-24T09:23:14Z,2021-11-24T09:23:14Z,MEMBER,@dcherian you had an opinion on this in #5983 - would you rather raise a `ValueError` here and advise to pass `da.data`? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1052740367