html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5959#issuecomment-969177424,https://api.github.com/repos/pydata/xarray/issues/5959,969177424,IC_kwDOAMm_X845xHlQ,8699967,2021-11-15T18:06:04Z,2021-11-15T18:06:04Z,CONTRIBUTOR,This works for rioxarray. Thanks :+1: ,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-969146368,https://api.github.com/repos/pydata/xarray/issues/5959,969146368,IC_kwDOAMm_X845xAAA,2448579,2021-11-15T17:33:57Z,2021-11-15T17:33:57Z,MEMBER,Thanks for the review @aurghs !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-969122428,https://api.github.com/repos/pydata/xarray/issues/5959,969122428,IC_kwDOAMm_X845w6J8,35919497,2021-11-15T17:08:38Z,2021-11-15T17:08:38Z,COLLABORATOR,"> @alexamici Could you please have a final look into this? Thank you @kmuehlbauer! LGTM","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-968640994,https://api.github.com/repos/pydata/xarray/issues/5959,968640994,IC_kwDOAMm_X845vEni,5821660,2021-11-15T08:20:25Z,2021-11-15T08:20:25Z,MEMBER,@alexamici Could you please have a final look into this?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964867173,https://api.github.com/repos/pydata/xarray/issues/5959,964867173,IC_kwDOAMm_X845grRl,5821660,2021-11-10T07:52:18Z,2021-11-10T07:52:18Z,MEMBER,"It seems that now the mocking works by specifying the correct import module string for `importlib_metadata` depending on which importlib is used. That should be ready for another review.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964224503,https://api.github.com/repos/pydata/xarray/issues/5959,964224503,IC_kwDOAMm_X845eOX3,5821660,2021-11-09T14:52:27Z,2021-11-09T14:52:27Z,MEMBER,I'll leave it as is for the next couple of days. I very much appreciate further reviews.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964221223,https://api.github.com/repos/pydata/xarray/issues/5959,964221223,IC_kwDOAMm_X845eNkn,5821660,2021-11-09T14:48:59Z,2021-11-09T14:48:59Z,MEMBER,"That did not seem to work, I'll revert.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964181699,https://api.github.com/repos/pydata/xarray/issues/5959,964181699,IC_kwDOAMm_X845eD7D,5821660,2021-11-09T14:05:32Z,2021-11-09T14:05:32Z,MEMBER,"It looks like these changes fix all pending issues. It would be very convenient to get a version `0.20.2` out in near time, since without it breaks testing of packages which implement xarray backends. @snowman2 I think this is ready for test now with `rioxarray`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964132373,https://api.github.com/repos/pydata/xarray/issues/5959,964132373,IC_kwDOAMm_X845d34V,5821660,2021-11-09T13:04:38Z,2021-11-09T13:04:38Z,MEMBER,"Obviously we have an extensive set of tests for the backend plugins here (https://github.com/pydata/xarray/blob/ae3fea0251711c027427578933b82d982a07b242/xarray/tests/test_plugins.py) but it still uses `pkg_resources`, so trying to adapt to importlib. ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964107601,https://api.github.com/repos/pydata/xarray/issues/5959,964107601,IC_kwDOAMm_X845dx1R,5821660,2021-11-09T12:29:08Z,2021-11-09T12:29:08Z,MEMBER,"Finally, some test is breaking. This test uses the old `pkg_resources` way and needs to be updated too. https://github.com/pydata/xarray/blob/ae3fea0251711c027427578933b82d982a07b242/xarray/tests/test_plugins.py#L29-L45 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-964102114,https://api.github.com/repos/pydata/xarray/issues/5959,964102114,IC_kwDOAMm_X845dwfi,5821660,2021-11-09T12:21:11Z,2021-11-09T12:21:11Z,MEMBER,"There seem to be two cases here. 1. equal entrypoints, introduced by importlib machinery (pointing to the same module) 2. multiple entrypoints with the same name (pointing to different modules) The first is remove via `set`. The second is handled according the old machinery by extracting the modules from `value`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254 https://github.com/pydata/xarray/pull/5959#issuecomment-963929073,https://api.github.com/repos/pydata/xarray/issues/5959,963929073,IC_kwDOAMm_X845dGPx,5821660,2021-11-09T08:41:24Z,2021-11-09T08:41:24Z,MEMBER,"Although this makes the error go away, it doesn't do the right thing. I'll have to think about this more thoroughly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1048309254