html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5886#issuecomment-949917258,https://api.github.com/repos/pydata/xarray/issues/5886,949917258,IC_kwDOAMm_X844npZK,41898282,2021-10-22T19:47:09Z,2021-10-28T22:42:43Z,CONTRIBUTOR,"## Unit Test Results
6 files 6 suites 56m 58s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""duration of all tests"")
16 281 tests 14 545 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 1 736 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
90 882 runs 82 702 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 8 180 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
Results for commit baad9de1.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661
https://github.com/pydata/xarray/pull/5886#issuecomment-954278227,https://api.github.com/repos/pydata/xarray/issues/5886,954278227,IC_kwDOAMm_X8444SFT,2448579,2021-10-28T22:41:53Z,2021-10-28T22:41:53Z,MEMBER,Thanks @TomNicholas ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661
https://github.com/pydata/xarray/pull/5886#issuecomment-954267050,https://api.github.com/repos/pydata/xarray/issues/5886,954267050,IC_kwDOAMm_X8444PWq,24736507,2021-10-28T22:16:50Z,2021-10-28T22:17:40Z,NONE,"Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2021-10-28 22:17:40 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661
https://github.com/pydata/xarray/pull/5886#issuecomment-954261248,https://api.github.com/repos/pydata/xarray/issues/5886,954261248,IC_kwDOAMm_X8444N8A,14371165,2021-10-28T22:06:01Z,2021-10-28T22:06:01Z,MEMBER,"> It would be nicer to know for certain that we are testing all the plot types with pint arrays, but I think that can maybe wait for another PR?
Agreed, it can wait for another time. This looks good to me. :)","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661
https://github.com/pydata/xarray/pull/5886#issuecomment-954253465,https://api.github.com/repos/pydata/xarray/issues/5886,954253465,IC_kwDOAMm_X8444MCZ,35968931,2021-10-28T21:58:24Z,2021-10-28T21:58:24Z,MEMBER,"> Did all of these changes print the warning?
I don't know - instead of testing all the cases I just made the `.values`->`.to_numpy()` change everywhere I could see. I think that makes sense given that:
(a) there are tests elsewhere that should guarantee that those two methods are equivalent for non-pint arrays,
(b) making those changes didn't break any existing tests,
(c) `.to_numpy()` was intended to be the new default for calling within plotting code.
> Would be nice if we could get these tested somehow.
I've added some tests for faceted line plots, faceted imshow, and faceted contourf. There is almost certainly some other type of plot or other edge case I haven't tested, but that's enough to show that this PR fixes what it intended to fix.
It would be nicer to know for certain that we are testing all the plot types with pint arrays, but I think that can maybe wait for another PR?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661
https://github.com/pydata/xarray/pull/5886#issuecomment-950377397,https://api.github.com/repos/pydata/xarray/issues/5886,950377397,IC_kwDOAMm_X844pZu1,14371165,2021-10-24T19:06:00Z,2021-10-24T19:06:00Z,MEMBER,Did all of these changes print the warning? Would be nice if we could get these tested somehow.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1033884661