html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5871#issuecomment-962498057,https://api.github.com/repos/pydata/xarray/issues/5871,962498057,IC_kwDOAMm_X845Xo4J,5635139,2021-11-06T19:21:46Z,2021-11-06T19:21:46Z,MEMBER,"Big win @dcherian ! Thanks a lot. By LoC, xarray just got 4% better in a single PR!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-951117633,https://api.github.com/repos/pydata/xarray/issues/5871,951117633,IC_kwDOAMm_X844sOdB,5635139,2021-10-25T16:54:48Z,2021-10-25T16:54:48Z,MEMBER,"Unless @shoyer has any objections — I think we were primarily delayed by Apache Beam, and they have unlocked that dependency, so I would vote to add it as a required dependency. The only realistic way this could be bad is if there's another package that is commonly installed with xarray that a) requires `typing_extensions`, b) forbids a recent version, c) won't remove that pin soon.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950304347,https://api.github.com/repos/pydata/xarray/issues/5871,950304347,IC_kwDOAMm_X844pH5b,5635139,2021-10-24T11:06:56Z,2021-10-24T11:06:56Z,MEMBER,"> I think @keewis mentioned we could drop 3.7 in December which is not that far away. Can we type `self` as `Any` for now and update later? What are your thoughts re adding the typing_extensions dependency?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950268614,https://api.github.com/repos/pydata/xarray/issues/5871,950268614,IC_kwDOAMm_X844o_LG,5635139,2021-10-24T06:26:24Z,2021-10-24T06:26:24Z,MEMBER,"I just checked Apache beam (the library that prevented us upgrading last time), and they now support typing-extensions<4, so I would vote to add that dependency, rather than drop 3.7.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950237563,https://api.github.com/repos/pydata/xarray/issues/5871,950237563,IC_kwDOAMm_X844o3l7,5635139,2021-10-24T00:27:31Z,2021-10-24T00:27:31Z,MEMBER,"Bah, `Protocol` isn't supported in 3.7! We could either revisit mandating `typing_extensions` or drop 3.7 (which is overdue since our change to only allow 24 months for python releases). Is it possible to mandate `typing_extensions` for _only_ 3.7?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950236575,https://api.github.com/repos/pydata/xarray/issues/5871,950236575,IC_kwDOAMm_X844o3Wf,5635139,2021-10-24T00:17:15Z,2021-10-24T00:17:15Z,MEMBER,"I fixed mypy! @Illviljan thanks for the `Protocol` suggestion. I had to make a different one per class, because the return type for `reduce` couldn't be generic (I think, unless there's a way...) Actually much more tedious was fixing `black` given line-breaks etc. Great work @dcherian !","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950229311,https://api.github.com/repos/pydata/xarray/issues/5871,950229311,IC_kwDOAMm_X844o1k_,5635139,2021-10-23T23:01:18Z,2021-10-23T23:01:18Z,MEMBER,"> I'm having trouble with mypy though. Please help! I tried for a while. I'm still trying!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240