html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5871#issuecomment-962118284,https://api.github.com/repos/pydata/xarray/issues/5871,962118284,IC_kwDOAMm_X845WMKM,2448579,2021-11-05T18:22:56Z,2021-11-05T18:22:56Z,MEMBER,Thanks for the reviews!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-962075979,https://api.github.com/repos/pydata/xarray/issues/5871,962075979,IC_kwDOAMm_X845WB1L,2448579,2021-11-05T17:20:31Z,2021-11-05T17:20:31Z,MEMBER,"> This can be merged as is. I just think it looks a little neater with |. :+1: I think we make this change project-wide if we want to do it (looks like pyupgrade supports it). @Illviljan can you open an issue please?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-954959122,https://api.github.com/repos/pydata/xarray/issues/5871,954959122,IC_kwDOAMm_X84464US,2448579,2021-10-29T18:26:19Z,2021-10-29T18:26:19Z,MEMBER,"All green! This should be good to go. Here are a couple of examples: https://xray--5871.org.readthedocs.build/en/5871/generated/xarray.core.groupby.DataArrayGroupBy.sum.html https://xray--5871.org.readthedocs.build/en/5871/generated/xarray.core.resample.DataArrayResample.sum.html","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950316866,https://api.github.com/repos/pydata/xarray/issues/5871,950316866,IC_kwDOAMm_X844pK9C,2448579,2021-10-24T12:30:40Z,2021-10-24T12:30:40Z,MEMBER,"It's ok to me. My hesitation is because we only need in a very small number of places IIUC. Happy to defer to the opinions of more experienced typers","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950295790,https://api.github.com/repos/pydata/xarray/issues/5871,950295790,IC_kwDOAMm_X844pFzu,2448579,2021-10-24T10:04:34Z,2021-10-24T10:04:34Z,MEMBER,I think @keewis mentioned we could drop 3.7 in December which is not that far away. Can we type `self` as `Any` for now and update later?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240 https://github.com/pydata/xarray/pull/5871#issuecomment-950181408,https://api.github.com/repos/pydata/xarray/issues/5871,950181408,IC_kwDOAMm_X844op4g,2448579,2021-10-23T17:01:02Z,2021-10-23T17:01:02Z,MEMBER,"Updated to generate resample reductions separately. This allows us to have nice examples in the docstring. I'm having trouble with mypy though. Please help! ``` xarray/core/_reductions.py:2662: error: ""DataArrayResampleReductions"" has no attribute ""reduce"" [attr-defined] xarray/core/_reductions.py:2737: error: ""DataArrayResampleReductions"" has no attribute ""reduce"" [attr-defined] xarray/core/_reductions.py:2805: error: ""DataArrayResampleReductions"" has no attribute ""reduce"" [attr-defined] xarray/core/_reductions.py:2872: error: ""DataArrayResampleReductions"" has no attribute ""reduce"" [attr-defined] xarray/core/_reductions.py:2939: error: ""DataArrayResampleReductions"" has no attribute ""reduce"" [attr-defined] ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1028110240