html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5847#issuecomment-955239781,https://api.github.com/repos/pydata/xarray/issues/5847,955239781,IC_kwDOAMm_X844781l,2448579,2021-10-30T14:06:37Z,2021-10-30T14:06:37Z,MEMBER,Thanks @caenrigen ,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 1, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-939065386,https://api.github.com/repos/pydata/xarray/issues/5847,939065386,IC_kwDOAMm_X843-QAq,41898282,2021-10-08T19:21:19Z,2021-10-29T22:56:29Z,CONTRIBUTOR,"## Unit Test Results
6 files 6 suites 51m 7s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""duration of all tests"")
16 290 tests 14 551 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 1 739 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
90 936 runs 82 738 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 8 198 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"")
Results for commit add9b1ae.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-949119077,https://api.github.com/repos/pydata/xarray/issues/5847,949119077,IC_kwDOAMm_X844kmhl,35968931,2021-10-22T00:43:16Z,2021-10-22T00:43:59Z,MEMBER,That `UnitStrippedWarning` might be the same one that I apparently forgot to fix [in #5561](https://github.com/pydata/xarray/pull/5561#discussion_r664708280)? I need to look more closely...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-949115762,https://api.github.com/repos/pydata/xarray/issues/5847,949115762,IC_kwDOAMm_X844klty,35968931,2021-10-22T00:40:00Z,2021-10-22T00:40:00Z,MEMBER,"> I would appreciate a lot if we keep the scope of this PR to what I have contributed so far, I am running out of bandwidth in the project I am involved and won't be able to add much more to this PR.
Thank you very much for your work so far @caenrigen ! We can take this PR from here :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-948958184,https://api.github.com/repos/pydata/xarray/issues/5847,948958184,IC_kwDOAMm_X844j_Po,31376402,2021-10-21T19:59:18Z,2021-10-21T20:00:04Z,CONTRIBUTOR,"Hi @Illviljan @keewis,
I have added tests and marked them as xfail
Accoriding to pytest docs
> A skip means that you expect your test to pass only if some conditions are met, otherwise pytest should skip running the test altogether. Common examples are skipping windows-only tests on non-windows platforms, or skipping tests that depend on an external resource which is not available at the moment (for example a database).
> An xfail means that you expect a test to fail for some reason. A common example is a test for a feature not yet implemented, or a bug not yet fixed. When a test passes despite being expected to fail (marked with pytest.mark.xfail), it’s an xpass and will be reported in the test summary.
This case seems exactly what xfail is meant for. But feel free to change this.
---
> Do the slice plots work with non-dimension coordinates? If so, we should maybe add a test with pint for that, too: units in non-dimension coordinates are not stripped.
It seems so, but it raises a `pint` warning despite the code producing the intended figure:
```python
import xarray as xr
import numpy as np
import matplotlib.pyplot as plt
import pytest
pint = pytest.importorskip(""pint"")
unit_registry = pint.UnitRegistry(force_ndarray=True)
coord_unit, coord_attrs = (unit_registry.m, {})
def test_units_in_slice_line_plot_labels_isel():
arr = xr.DataArray(
name=""var_a"",
data=np.array([[1, 2], [3, 4]]),
coords=dict(
a=(""x"", np.array([5, 6]) * coord_unit, coord_attrs),
b=(""y"", np.array([7, 8])),
),
dims=(""x"", ""y""),
)
arr.isel(x=0).plot(marker=""o"")
assert plt.gca().get_title() == ""a = 5 [meter]""
return arr
test_units_in_slice_line_plot_labels_isel()
```
---
I would appreciate a lot if we keep the scope of this PR to what I have contributed so far, I am running out of bandwidth in the project I am involved and won't be able to add much more to this PR.
Kind regards,
Victor","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-945146242,https://api.github.com/repos/pydata/xarray/issues/5847,945146242,IC_kwDOAMm_X844VcmC,14808389,2021-10-17T15:36:28Z,2021-10-17T15:36:28Z,MEMBER,"> but let it `xfail` for now with a nice explanation
yes, let's wait until the index refactor has progressed a bit more. I'd `skip` it, though: we know that the test will fail right now, so there's no point in running the test (and it's also what all the other tests do, so it's better to be consistent).
Do the slice plots work with non-dimension coordinates? If so, we should maybe add a test with `pint` for that, too: units in non-dimension coordinates are not stripped.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-945070918,https://api.github.com/repos/pydata/xarray/issues/5847,945070918,IC_kwDOAMm_X844VKNG,14371165,2021-10-17T08:14:35Z,2021-10-17T08:14:35Z,MEMBER,"I thought a little about the pint issue and for dataarrays you can probably modify the `attrs` dict around here:
https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/core/dataarray.py#L133
But I'm not sure it's worth the effort considering the explicit indexes rework is ongoing, #5692, and that should hopefully allow pint quantities on coords.
I'd suggest adding a pint test anyway, but let it `xfail` for now with a nice explanation. The TODO comment might get lost in the sea of code.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-945016426,https://api.github.com/repos/pydata/xarray/issues/5847,945016426,IC_kwDOAMm_X844U85q,14371165,2021-10-16T22:37:44Z,2021-10-16T22:37:44Z,MEMBER,"That's rather annoying that the pint units are dropped:
```python
arr = xr.DataArray(
name=""var_a"",
data=np.array([[1, 2], [3, 4]]),
# TODO make coord a Quantity once unit-aware indexes supported
coords=dict(
a=(""a"", pint.Quantity(np.array([5, 6]), ""s"")),
b=(""b"", np.array([7, 8]), {""unit"": ""s""}),
),
dims=(""a"", ""b""),
)
C:\Users\J.W\Documents\GitHub\xarray\xarray\core\utils.py:118: UnitStrippedWarning: The unit of the quantity is stripped when downcasting to ndarray.
index = pd.Index(np.asarray(array), **kwargs)
```
I think xarray could've at least moved the `pint unit` string to `arr.a.attrs[""units""]` before downcasting it to ndarrays.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-944278576,https://api.github.com/repos/pydata/xarray/issues/5847,944278576,IC_kwDOAMm_X844SIww,31376402,2021-10-15T13:01:32Z,2021-10-15T13:02:24Z,CONTRIBUTOR,"Just checked and this cannot be tested for pint units, there is already a comment in there explaining this:
```python
# TODO make coord a Quantity once unit-aware indexes supported""
```
Since the slice units come from a coordinate these units can't be pint units (at least not yet).
I added a new test for the units in the title of a slice line plot, also added the same comment about pint units.
Who should I ping for the PR approval?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447
https://github.com/pydata/xarray/pull/5847#issuecomment-944208315,https://api.github.com/repos/pydata/xarray/issues/5847,944208315,IC_kwDOAMm_X844R3m7,31376402,2021-10-15T11:01:17Z,2021-10-15T11:01:17Z,CONTRIBUTOR,"> This is great, thanks @caenrigen !
>
> It just needs a couple of tests - ideally one for basic behaviour like you've shown in your example (which [should probably live here](https://github.com/pydata/xarray/blob/5499949b5937277dcd599a182201d0e2fc5e818e/xarray/tests/test_plot.py#L166)), and another [checking that it works with pint units](https://github.com/pydata/xarray/blob/5499949b5937277dcd599a182201d0e2fc5e818e/xarray/tests/test_units.py#L5601) like we added in #5561.
Hi @TomNicholas!
Thank you for the input and guidance, will work on adding the tests 🙂
Cheers","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1021396447